[0.59.x] URLSearchParams 'Error: not implemented'

[retyui]

🐛 Bug Report

I used next code to check support URLSearchParams

if ( !global.URLSearchParams ) {
   global.URLSearchParams = require('url-search-params')
}

But now it doesn't work because you add own "implementation"

react-native/Libraries/Blob/URL.js

Lines 69 to 71 in e605709

	get(name) {
	throw new Error('not implemented');
	}

And a can't overwrite it

To Reproduce

const a = new URLSearchParams()
a.set('1','2');
a.toString()

Expected Behavior

My code don't broken!

Remove these polyfills:

react-native/Libraries/Core/setUpXHR.js

Lines 31 to 32 in e605709

	polyfillGlobal('URL', () => require('URL').URL); // flowlint-line untyped-import:off
	polyfillGlobal('URLSearchParams', () => require('URL').URLSearchParams); // flowlint-line untyped-import:off

Code Example

// I try force set custom 
global.URLSearchParams = require('url-search-params');

// But it works only with
import { polyfillGlobal } from 'react-native/Libraries/Utilities/PolyfillFunctions';

polyfillGlobal('URLSearchParams', () => require('url-search-params'));

Environment

  React Native Environment Info:
    System:
      OS: Linux 4.15 Linux Mint 19.1 (Tessa)
      CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
      Memory: 1.27 GB / 15.51 GB
      Shell: 2.7.1 - /usr/bin/fish
    Binaries:
      Node: 10.15.3 - /usr/bin/node
      Yarn: 1.13.0 - /usr/bin/yarn
      npm: 6.4.1 - /usr/bin/npm
    npmPackages:
      react: ^16.8.1 => 16.8.4 
      react-native: ^0.59.0 => 0.59.0 
    npmGlobalPackages:
      react-native-cli: 2.0.1

[dulmandakh]

@matthargett could you please look into the issue

[Tino-F]

I'm also having this issue.

[lutakyn]

Can someone take me through how to setup on IOS after ejecting from expo.Facebook isn't giving me any better news on this issue.Guys how did you solve this.i always get third party error

[retyui]

// index.js

import { URL, URLSearchParams } from 'whatwg-url';
import { Buffer } from 'buffer';


// react-native 0.59 add own global URLSearchParams without implementation
// https://github.com/facebook/react-native/blob/e6057095adfdc77ccbbff1c97b1e86b06dae340b/Libraries/Blob/URL.js#L66
global.Buffer = Buffer;
global.URL = URL;
global.URLSearchParams = URLSearchParams;

[matthargett]

Hi! Yes, we purposefully didn't bring in the full whatwg-url package because it has a major impact on the bundle size due to needing to support many unicode corner cases. I expanded our narrow implementation slightly to support apollo-server's use of URL. Is there a specific library that isn't interacting properly?

Once you narrow the use case, I can suggest what can be done. If you need the fully spec-compliant URL implementation for reasons you can't specify publicly, then the workaround in the comment above will work (at the cost of the bundle size impact).

[leethree]

@matthargett I think the polyfill should be removed from global because it's not standard compliant and it's not documented properly in React Native JavaScript Environment.

Even the most basic use case will result in broken URL because of this polyfill. I filed a new issue #24428 for it.

I would argue that a broken or incomplete polyfill is worse than no polyfill at all. Exposing it in global will let people assume it's safe to use it.

[matthargett]

Hi @leethree , thanks for your comments.

Because URL needs to integrate with React Native's blob support to enable an opaque reference that avoids huge copies, the URL is customized. Many React Native applications use the included URL and URLSearchParams without issues, even via complex libraries such as apollo-server. I'm open to suggestions (and especially PRs) that are able to meet the needs.

In the meantime, I'm happy to submit a PR myself to fix specific use cases that happen via libraries (such as apollo-server, etc). If you can tell me the use case, I can create a PR with tests pretty quickly.

[royisch]

@matthargett - how do you suggest to proceed? is there a workaround? Currently my app breaks from this, and im not sure why this breaks it

[royisch]

im not using appolo, i just see this error and not sure what has caused it all of a sudden. I saw it since i upgraded from 0.58.5 to 0.59

[leethree]

@matthargett the non-standard-compliant polyfill will cause issues because many 3rd-party libraries uses the global URL. I don't think it's reasonable to expect every app developer to throughly test whether this customised URL implementation is compatible with all the libraries. (That is why we have web standards in the first place.)

Many React Native applications use the included URL and URLSearchParams without issues

As you can see from the comments above, the new version breaks people's apps with an obscure error even if it was working before. It means a breaking change was introduced without any documentation or workaround.

1. If this URL implementation is intended to be used by app developers, it should be standard-compliant. I think URL and URLSearchParams are included in JavaScriptCore which is already provided by React Native 0.59. If that is the case, I don't understand why we still need this customised URL implementation.

2. If this URL implementation is only intended to be used internally by Blob, it should not be exported to the global scope. Or it should be renamed to something like RNURL to avoid confusing. App developers can actively decide if they want to use this customised version of URL.

In any case, its behaviour should be documented in some way. And a clear workaround should be provided with the error message.

[royisch]

I second @leethree - basically it breaks the ability to upgrade to the new version 0.59. This is a JSC implementation of URL, it cannot assume that this will change as libraries use it

[peterleilei86]

I am currently upgrading react native version from 0.57 to 0.59.5 and this issue breaks my app. I tried @retyui 's comment. It does not work. This does not work either

// But it works only with
import { polyfillGlobal } from 'react-native/Libraries/Utilities/PolyfillFunctions';

polyfillGlobal('URLSearchParams', () => require('url-search-params'));

I am using a third-party lib that uses url-search-params, which is the reason why I got this not implemented error.

Could anyone suggest any solution or workaround for this issue? This is stopping react-native being upgraded to 59.

[peterleilei86]

This is what's working for me.

// index.js
import 'node-libs-react-native/globals';
import { polyfillGlobal } from 'react-native/Libraries/Utilities/PolyfillFunctions';

polyfillGlobal('URLSearchParams', () => require('whatwg-url').URLSearchParams);

[schellack]

The only way I can get this to work, for example with aws-amplify's oauth, is to not only polyfill URLSearchParams as mentioned above, but to also delete the global reference:
delete global.URLSearchParams;

This causes other issues, so I'd love to hear if anyone has found a more reliable solution.

[liopoos]

Hey! I used an other npm package and had fixed it.
search-params

[florian-milky]

Why is this closed? This is still an issue in 0.61.5

[igorrfc]

+1 @florian-milky
I'm facing this issue at 0.61.5 as well

[a-tokyo]

I'm facing this issue at 0.61.5 as well

[Imran-cse]

I'm facing this issue at 0.61.4 as well. Don't know why the issue is closed, it should be fixed.

[a-tokyo]

Solution:

1. install the polyfill yarn add react-native-url-polyfill
2. add this to your index.js

/* polyfills */
/** URL polyfill */
import 'react-native-url-polyfill/auto';

Explanation: To ensure it being light weight, react native doesn't fully support everything the web supports. That's why sometimes we need RN polyfills

[halileohalilei]

Why is this issue closed without any resolution? This is still an issue in RN 0.62.2

[a-tokyo]

@halileohalilei Check my comment above, it should solve your issue 👍

[halileohalilei]

Thanks @a-tokyo, that's what I went with in the end, it works like a charm. But still some recommended solution from the maintainers would be better instead of a workaround.

[joshbuchea]

This seems like an excellent candidate to add to the React Native documentation.