Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include sourcesContent in composed Hermes source map #26086

Closed
motiz88 opened this issue Aug 16, 2019 · 12 comments
Closed

Include sourcesContent in composed Hermes source map #26086

motiz88 opened this issue Aug 16, 2019 · 12 comments
Assignees
@motiz88
Labels
Bug p: Facebook Partner: Facebook Platform: Android Android applications. Ran Commands One of our bots successfully processed a command. RN Team Stale There has been a lack of activity on this issue and it may be closed soon. Tech: Hermes Hermes Engine: https://hermesengine.dev/ Tool: Gradle

Comments

@motiz88
Copy link
Contributor

motiz88 commented Aug 16, 2019

React Native version: >= 0.60.2

Steps To Reproduce

  1. Build a new RN app in release mode with Hermes.
  2. The source map under generated/sourcemaps/react/ does not contain the sourcesContent field.

Describe what you expected to happen:

The source map should contain a fully-populated sourcesContent field.

More context: facebook/hermes#85 opened by @bengourley
@motiz88 motiz88 added Platform: Android Android applications. Type: Enhancement A new feature or enhancement of an existing feature. Tool: Gradle Tech: Hermes Hermes Engine: https://hermesengine.dev/ labels Aug 16, 2019
@motiz88 motiz88 self-assigned this Aug 16, 2019
@react-native-bot

This comment has been minimized.

Sign in to view
@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. Resolution: No Template labels Aug 16, 2019
@motiz88 motiz88 added RN Team and removed Ran Commands One of our bots successfully processed a command. Resolution: No Template labels Aug 16, 2019
@motiz88 motiz88 reopened this Aug 16, 2019
@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. Resolution: No Template labels Aug 16, 2019
@crutkas crutkas reopened this Aug 16, 2019
@hramos hramos added Bug p: Facebook Partner: Facebook and removed Type: Enhancement A new feature or enhancement of an existing feature. Resolution: No Template labels Aug 16, 2019
@hramos hramos reopened this Aug 16, 2019
@stale
Copy link

stale bot commented Nov 14, 2019

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Nov 14, 2019
@bengourley
Copy link

As far as I know nothing has changed, can anybody else shed any light?

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Nov 18, 2019
@stale
Copy link

stale bot commented Feb 16, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Feb 16, 2020
@safaiyeh
Copy link
Contributor

Should this issue be on the Hermes repo?

@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Feb 16, 2020
@motiz88
Copy link
Contributor Author

motiz88 commented Feb 16, 2020

No, the relevant build script is part of the RN+Hermes integration which lives in this repo.

@bengourley bengourley mentioned this issue Mar 4, 2020
Closed
@stale
Copy link

stale bot commented May 16, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label May 16, 2020
@stale
Copy link

stale bot commented May 23, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed May 23, 2020
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2020
@xljones xljones mentioned this issue Jun 3, 2020
Closed
@motiz88
Copy link
Contributor Author

motiz88 commented Jun 3, 2020

This issue still exists.

@motiz88 motiz88 reopened this Jun 3, 2020
@stale stale bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Jun 3, 2020
@facebook facebook unlocked this conversation Jun 29, 2020
@motiz88 motiz88 mentioned this issue Jun 29, 2020
Closed
motiz88 added a commit to motiz88/metro that referenced this issue Jun 29, 2020
@motiz88 @facebook-github-bot
metro-source-map: propagate sourcesContent when composing source maps
95d4d53 
Summary:
* Implements the `sourceContentFor` API from `source-map` in Metro's `Consumer`.
* Copies source contents in `composeSourceMaps` if they exist.

Related issues: facebook/react-native#26086, facebook/hermes#85. We'll be able to close the RN issue once this lands in the version of `metro-source-map` used in RN master.

Differential Revision: D22284159

fbshipit-source-id: 996f485a95190319a6482da518dcf32a4e7a8a96
@motiz88
Copy link
Contributor Author

motiz88 commented Jun 29, 2020

facebook/metro#574 will fix this. Apologies for the long delay.

facebook-github-bot pushed a commit to facebook/metro that referenced this issue Jun 29, 2020
@motiz88 @facebook-github-bot
metro-source-map: propagate sourcesContent when composing source maps (…
b1e3941 
…#574)

Summary:
Pull Request resolved: #574

* Implements the `sourceContentFor` API from `source-map` in Metro's `Consumer`.
* Copies source contents in `composeSourceMaps` if they exist.

Related issues: facebook/react-native#26086, facebook/hermes#85. We'll be able to close the RN issue once this lands in the version of `metro-source-map` used in RN master.

Reviewed By: cpojer

Differential Revision: D22284159

fbshipit-source-id: ac3080ce772f664d7b58559f109b71a9252c325b
@stale
Copy link

stale bot commented Oct 4, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 4, 2020
@stale
Copy link

stale bot commented Oct 12, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Oct 12, 2020
@facebook facebook locked as resolved and limited conversation to collaborators Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@motiz88 motiz88

Labels
Bug p: Facebook Partner: Facebook Platform: Android Android applications. Ran Commands One of our bots successfully processed a command. RN Team Stale There has been a lack of activity on this issue and it may be closed soon. Tech: Hermes Hermes Engine: https://hermesengine.dev/ Tool: Gradle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@hramos @bengourley @crutkas @motiz88 @safaiyeh @react-native-bot