Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Letter spacing CSS property #457

Closed
lachlanjc opened this issue Mar 29, 2015 · 5 comments
Closed

Letter spacing CSS property #457

lachlanjc opened this issue Mar 29, 2015 · 5 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@lachlanjc
Copy link

There doesn’t seem to be a StyleSheet property for the letter-spacing CSS property. Is it just called something else or does it not exist yet? If not, it’d be a fantastic addition.
@sahrens
Copy link
Contributor

sahrens commented Mar 29, 2015

Not supported, sorry. Would love a PR ;)

On Mar 29, 2015, at 2:14 PM, Lachlan Campbell notifications@github.com wrote:

There doesn’t seem to be a StyleSheet property for the letter-spacing CSS property. Is it just called something else or does it not exist yet? If not, it’d be a fantastic addition.

—
Reply to this email directly or view it on GitHub.

@lachlanjc
Copy link
Author

@sahrens Do you mean iOS doesn’t support it, or just that React Native doesn’t yet support it?

@sahrens
Copy link
Contributor

sahrens commented Mar 30, 2015

I believe iOS supports letter spacing via NSKernAttributeName on NSAttributedString, which should be pretty easy to map into in react native, but hasn't been done yet ;)

On Mar 29, 2015, at 6:43 PM, Lachlan Campbell notifications@github.com wrote:

@sahrens Do you mean iOS doesn’t support it, or just that React Native doesn’t yet support it?

—
Reply to this email directly or view it on GitHub.

vkurchatkin added a commit to vkurchatkin/react-native that referenced this issue Mar 30, 2015
@vkurchatkin
Add letterSpacing style property for Text
f2f4204 
Fixes facebook#457
@vkurchatkin vkurchatkin mentioned this issue Mar 30, 2015
Closed
@lachlanjc
Copy link
Author

Got it @sahrens. I will definitely check out adding it soon!

@frantic
Copy link
Contributor

frantic commented Mar 30, 2015

See #482

@frantic frantic closed this as completed Mar 30, 2015
vkurchatkin added a commit to vkurchatkin/react-native that referenced this issue Mar 30, 2015
@vkurchatkin
Add letterSpacing style property for Text
06e01e6 
Fixes facebook#457
vkurchatkin added a commit to vkurchatkin/react-native that referenced this issue Mar 30, 2015
@vkurchatkin
Add letterSpacing style property for Text
d1451fe 
Fixes facebook#457
vkurchatkin added a commit to vkurchatkin/react-native that referenced this issue Apr 1, 2015
@vkurchatkin
Add letterSpacing style property for Text
f3f0828 
Fixes facebook#457
vjeux pushed a commit to vjeux/react-native that referenced this issue May 13, 2015
@vkurchatkin
Add letterSpacing style property for Text
7195e28 
Summary:
Fixes facebook#457
Closes facebook#482
Github Author: Vladimir Kurchatkin <vladimir.kurchatkin@gmail.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
vjeux pushed a commit to vjeux/react-native that referenced this issue May 13, 2015
@vkurchatkin @vjeux
Add letterSpacing style property for Text
a142ed5 
Summary:
Fixes facebook#457
Closes facebook#482
Github Author: Vladimir Kurchatkin <vladimir.kurchatkin@gmail.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
rozele referenced this issue in microsoft/react-native-windows May 25, 2016
@vkurchatkin @vjeux
Add letterSpacing style property for Text
66e4379 
Summary:
Fixes #457
Closes facebook/react-native#482
Github Author: Vladimir Kurchatkin <vladimir.kurchatkin@gmail.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
@jasongrishkoff jasongrishkoff mentioned this issue Feb 23, 2017
Closed
jasongrishkoff referenced this issue Feb 24, 2017
@sahrens @facebook-github-bot
Better ListView - FlatList
a345748 
Summary:
We really need a better list view - so here it is!

Main changes from existing `ListView`:

* Items are "virtualized" to limit memory - that is, items outside of the render window are unmounted and their memory is reclaimed. This means that instance state is not preserved when items scroll out of the render window.
* No `DataSource` - just a simple `data` prop of shape `Array<any>`. By default, they are expected to be of the shape `{key: string}` but a custom `rowExtractor` function can be provided for different shapes, e.g. graphql data where you want to map `id` to `key`. Note the underlying `VirtualizedList` is much more flexible.
* Fancy `scrollTo` functionality: `scrollToEnd`, `scrollToIndex`, and `scrollToItem` in addition to the normal `scrollToOffset`.
* Built-in pull to refresh support - set set the `onRefresh` and `refreshing` props.
* Rendering additional rows is usually done with low priority, after any interactions/animations complete, unless we're about to run out of rendered content. This should help apps feel more responsive.
* Component props replace render functions, e.g. `ItemComponent: ReactClass<{item: Item, index: number}>` replaces `renderRow: (...) => React.Element<*>`
* Supports dynamic items automatically by using `onLayout`, or `getItemLayout` can be provided for a perf boost and smoother `scrollToIndex` and scroll bar behavior.
* Visibility callback replaced with more powerful viewability callback and works in vertical and horizontal mode on at least Android and iOS, but probably other platforms as well. Extra power comes from the `viewablePercentThreshold` that lets the client decide when an item should be considered viewable.

Demo:

https://www.facebook.com/groups/576288835853049/permalink/753923058089625/

Reviewed By: yungsters

Differential Revision: D4412469

fbshipit-source-id: e2d891490bf76fe14df49294ecddf78a58adcf23
@facebook facebook locked as resolved and limited conversation to collaborators May 29, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add letterSpacing style property for Text vkurchatkin/react-native
4 participants
@frantic @sahrens @lachlanjc @react-native-bot