-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dimensions.get('window').height is sometimes wrong on Android #4934
Comments
Hey jaysoo, thanks for reporting this issue! React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.
|
Yeah, Dimensions is badly broken in android, if you rotate the screen the dimensions will still be in their old values. If you close the application and open it again but with the orientation changed, the values will be correct. The Dimension values keep their original values as opposed to change when the device orientation changes. Also a way to assign a callback when the Dimensions change would be nice, if I could register a callback in |
@DanielHoffmann I created a module just so I can get going on my own project. https://github.com/jaysoo/react-native-extra-dimensions-android A callback would be easy to implement. Although I'd prefer it being in RN core if it makes sense. |
bump... this is a pretty major issue, how has this not been fixed? |
Any update on this Issue ? |
Can we get an update on this issue, I'm still experiencing this with RN 0.55.2 along with CRNA. |
Closed with no explanation...? Can anyone comment on this issue please? @cpojer ? |
This only happens on a real device (I'm using OnePlus One). Could not reproduce on an emulator.
It seems that the first load, the height excludes the soft menu bar, but on subsequent reloads it includes it. (the soft menu bar for me is 48).
Here's the code I was running in my app:
First load
Reload
The text was updated successfully, but these errors were encountered: