This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
LL-451 Bottom modal glitches sometimes on certain Android phones #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gre
reviewed
Dec 7, 2018
|
i'm setting a HODL because we'll try to merge after apple submission (not sure about risk of modal lib bump and this only concerns Android) |
Arnaud97234
approved these changes
Dec 10, 2018
Arnaud97234
suggested changes
Dec 10, 2018
gre
previously approved these changes
Dec 13, 2018
Arnaud97234
previously requested changes
Dec 13, 2018
There was a problem hiding this comment.
Some drawer still have the bug on Android 9, Galaxy S9.
See comment in Jira : https://ledgerhq.atlassian.net/browse/LL-451
|
wonder if it's really blocking if the bug is only remaining on 1 device. wdyt @gre |
|
If it's a regression on that device then I feel yes it's blocking. Better have a functional button with a glitchy UI (develop) rather than a button not reachable |
|
(the un-reachable button regression has been fixed, btw) |
gre
approved these changes
Dec 18, 2018
MortalKastor
dismissed
Arnaud97234’s stale review
Should be fixed for good this time
Arnaud97234
approved these changes
Dec 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some Android phones, under some conditions, the bottom modal shows a ugly glitch:
This PR change that to something less ugly, but still suboptimal:
It's not a real fix, but:
Also, as a bonus, this PR fixes facebook/react-native#4934.
This could fix the weird statusbar glitch on Android where there's too much top padding under some undetermined conditions.
Maybe.
I don't know.
It's Friday.
Type
Bug Fix(ish)
Context
https://ledgerhq.atlassian.net/browse/LL-451
Parts of the app affected / Test plan
On Galaxy S9, set the navigation bar to self hide then spam a modal until its bottom margin is too tall rather than showing the underlying UI.