Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in ResolutionRequest.js #11983

Closed
wants to merge 2 commits into from
Closed

Fix typo in ResolutionRequest.js #11983

wants to merge 2 commits into from

Conversation

radko93
Copy link
Contributor

@radko93 radko93 commented Jan 19, 2017

Small fix:
Fix typo in error message - should be npm start --reset-cache

@radko93
Fix typo in ResolutionRequest.js
0feafb7 
Fix:
Fix typo in error message - should be `npm start --reset-cache`
@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jan 19, 2017
@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jan 20, 2017
@facebook-github-bot
Copy link
Contributor

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@radko93 radko93 deleted the patch-1 branch January 21, 2017 12:33
cpojer pushed a commit to facebook/metro that referenced this pull request Jan 26, 2017
@radko93 @facebook-github-bot
Fix typo in ResolutionRequest.js
673b171 
Summary:
Small fix:
Fix typo in error message - should be `npm start --reset-cache`
Closes facebook/react-native#11983

Reviewed By: AsyncDBConnMarkedDownDBException

Differential Revision: D4443749

Pulled By: hramos

fbshipit-source-id: eeaa531180c58a85df482fe3162b2a0b2169c891
edmofro pushed a commit to edmofro/react-native that referenced this pull request Feb 6, 2017
@radko93
Fix typo in ResolutionRequest.js
42e427e 
Summary:
Small fix:
Fix typo in error message - should be `npm start --reset-cache`
Closes facebook#11983

Reviewed By: AsyncDBConnMarkedDownDBException

Differential Revision: D4443749

Pulled By: hramos

fbshipit-source-id: eeaa531180c58a85df482fe3162b2a0b2169c891
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 7, 2017
@radko93 @nicktate
Fix typo in ResolutionRequest.js
99529b1 
Summary:
Small fix:
Fix typo in error message - should be `npm start --reset-cache`
Closes facebook#11983

Reviewed By: AsyncDBConnMarkedDownDBException

Differential Revision: D4443749

Pulled By: hramos

fbshipit-source-id: eeaa531180c58a85df482fe3162b2a0b2169c891
normanjoyner pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@radko93 @normanjoyner
Fix typo in ResolutionRequest.js
3f8ebfa 
Summary:
Small fix:
Fix typo in error message - should be `npm start --reset-cache`
Closes facebook#11983

Reviewed By: AsyncDBConnMarkedDownDBException

Differential Revision: D4443749

Pulled By: hramos

fbshipit-source-id: eeaa531180c58a85df482fe3162b2a0b2169c891
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@radko93 @nicktate
Fix typo in ResolutionRequest.js
b7505e2 
Summary:
Small fix:
Fix typo in error message - should be `npm start --reset-cache`
Closes facebook#11983

Reviewed By: AsyncDBConnMarkedDownDBException

Differential Revision: D4443749

Pulled By: hramos

fbshipit-source-id: eeaa531180c58a85df482fe3162b2a0b2169c891
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@radko93 @nicktate
Fix typo in ResolutionRequest.js
31030d8 
Summary:
Small fix:
Fix typo in error message - should be `npm start --reset-cache`
Closes facebook#11983

Reviewed By: AsyncDBConnMarkedDownDBException

Differential Revision: D4443749

Pulled By: hramos

fbshipit-source-id: eeaa531180c58a85df482fe3162b2a0b2169c891
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@radko93 @nicktate
Fix typo in ResolutionRequest.js
1cbd56d 
Summary:
Small fix:
Fix typo in error message - should be `npm start --reset-cache`
Closes facebook#11983

Reviewed By: AsyncDBConnMarkedDownDBException

Differential Revision: D4443749

Pulled By: hramos

fbshipit-source-id: eeaa531180c58a85df482fe3162b2a0b2169c891
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@radko93 @nicktate
Fix typo in ResolutionRequest.js
0878844 
Summary:
Small fix:
Fix typo in error message - should be `npm start --reset-cache`
Closes facebook#11983

Reviewed By: AsyncDBConnMarkedDownDBException

Differential Revision: D4443749

Pulled By: hramos

fbshipit-source-id: eeaa531180c58a85df482fe3162b2a0b2169c891
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@radko93 @nicktate
Fix typo in ResolutionRequest.js
196c22e 
Summary:
Small fix:
Fix typo in error message - should be `npm start --reset-cache`
Closes facebook#11983

Reviewed By: AsyncDBConnMarkedDownDBException

Differential Revision: D4443749

Pulled By: hramos

fbshipit-source-id: eeaa531180c58a85df482fe3162b2a0b2169c891
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@radko93 @nicktate
Fix typo in ResolutionRequest.js
af69cfa 
Summary:
Small fix:
Fix typo in error message - should be `npm start --reset-cache`
Closes facebook#11983

Reviewed By: AsyncDBConnMarkedDownDBException

Differential Revision: D4443749

Pulled By: hramos

fbshipit-source-id: eeaa531180c58a85df482fe3162b2a0b2169c891
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@radko93 @nicktate
Fix typo in ResolutionRequest.js
727f015 
Summary:
Small fix:
Fix typo in error message - should be `npm start --reset-cache`
Closes facebook#11983

Reviewed By: AsyncDBConnMarkedDownDBException

Differential Revision: D4443749

Pulled By: hramos

fbshipit-source-id: eeaa531180c58a85df482fe3162b2a0b2169c891
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@radko93 @nicktate
Fix typo in ResolutionRequest.js
1bee729 
Summary:
Small fix:
Fix typo in error message - should be `npm start --reset-cache`
Closes facebook#11983

Reviewed By: AsyncDBConnMarkedDownDBException

Differential Revision: D4443749

Pulled By: hramos

fbshipit-source-id: eeaa531180c58a85df482fe3162b2a0b2169c891
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@radko93 @nicktate
Fix typo in ResolutionRequest.js
90fe7f1 
Summary:
Small fix:
Fix typo in error message - should be `npm start --reset-cache`
Closes facebook#11983

Reviewed By: AsyncDBConnMarkedDownDBException

Differential Revision: D4443749

Pulled By: hramos

fbshipit-source-id: eeaa531180c58a85df482fe3162b2a0b2169c891
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@radko93 @nicktate
Fix typo in ResolutionRequest.js
812a1c7 
Summary:
Small fix:
Fix typo in error message - should be `npm start --reset-cache`
Closes facebook#11983

Reviewed By: AsyncDBConnMarkedDownDBException

Differential Revision: D4443749

Pulled By: hramos

fbshipit-source-id: eeaa531180c58a85df482fe3162b2a0b2169c891
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@radko93 @nicktate
Fix typo in ResolutionRequest.js
adb5924 
Summary:
Small fix:
Fix typo in error message - should be `npm start --reset-cache`
Closes facebook#11983

Reviewed By: AsyncDBConnMarkedDownDBException

Differential Revision: D4443749

Pulled By: hramos

fbshipit-source-id: eeaa531180c58a85df482fe3162b2a0b2169c891
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@radko93 @nicktate
Fix typo in ResolutionRequest.js
3a4231b 
Summary:
Small fix:
Fix typo in error message - should be `npm start --reset-cache`
Closes facebook#11983

Reviewed By: AsyncDBConnMarkedDownDBException

Differential Revision: D4443749

Pulled By: hramos

fbshipit-source-id: eeaa531180c58a85df482fe3162b2a0b2169c891
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@radko93 @nicktate
Fix typo in ResolutionRequest.js
79ac89f 
Summary:
Small fix:
Fix typo in error message - should be `npm start --reset-cache`
Closes facebook#11983

Reviewed By: AsyncDBConnMarkedDownDBException

Differential Revision: D4443749

Pulled By: hramos

fbshipit-source-id: eeaa531180c58a85df482fe3162b2a0b2169c891
nicktate pushed a commit to nicktate/react-native that referenced this pull request Feb 9, 2017
@radko93 @nicktate
Fix typo in ResolutionRequest.js
9c310f7 
Summary:
Small fix:
Fix typo in error message - should be `npm start --reset-cache`
Closes facebook#11983

Reviewed By: AsyncDBConnMarkedDownDBException

Differential Revision: D4443749

Pulled By: hramos

fbshipit-source-id: eeaa531180c58a85df482fe3162b2a0b2169c891
@cooperka
Copy link
Contributor

cooperka commented Mar 15, 2017 •
edited
Loading

Hi @radko93, this doesn't work for me without the double dash. I thought the -- was necessary to pass the --reset-cache flag through to node node_modules/react-native/local-cli/cli.js start instead of applying it to npm start. Is it possibly project dependent?

@radko93
Copy link
Contributor Author

radko93 commented Mar 17, 2017

It could be related to npm or node version.

@cooperka
Copy link
Contributor

Hmm, based on the comments here it looks like using the double dash is much more common. I honestly don't know how it would work without it, since npm doesn't understand that flag and it needs to be passed through.

Do you think we should open an issue, or how should this be resolved? If it truly works for you without the double dash, something very weird is going on 😕

@radko93 I'm on node v7.7.1, npm v4.1.2, and RN v0.42.0, what about you?

@hramos
Copy link
Contributor

hramos commented Mar 17, 2017

@cooperka I merged this in and I'm willing to look at a PR to revert this if it turns out to be inaccurate.

cooperka added a commit to cooperka/react-native that referenced this pull request Mar 17, 2017
@cooperka
Fix suggestion to "npm start -- --reset-cache"
1da8eea 
As discussed in facebook#11983. The double dash is necessary to pass through the argument to node. Based on the comments [here](facebook#1924 (comment)), it looks like most people use the double dash; it's unclear whether it would do anything at all if the dashes were omitted. If anyone else has better insight, let me know!

@hramos please review, thank you.

This reverts commit f521e99.
@cooperka cooperka mentioned this pull request Mar 17, 2017
Closed
cooperka added a commit to cooperka/react-native that referenced this pull request Mar 18, 2017
@cooperka
Fix suggestion to "npm start -- --reset-cache"
b4da103 
As discussed in facebook#11983. The double dash is necessary to pass through the argument to node. Based on the comments [here](facebook#1924 (comment)), it looks like most people use the double dash; it's unclear whether it would do anything at all if the dashes were omitted. If anyone else has better insight, let me know!

@hramos please review, thank you.

This reverts commit f521e99.
facebook-github-bot pushed a commit to facebook/metro that referenced this pull request Mar 18, 2017
@cooperka @facebook-github-bot
Fix suggestion to "npm start -- --reset-cache"
bbd4669 
Summary:
As discussed in facebook/react-native#11983. The double dash is necessary to pass through the argument to node. Based on the comments [here](facebook/react-native#1924 (comment)), it looks like most people use the double dash; it's unclear whether it would do anything at all if the dashes were omitted. If anyone else has better insight, let me know!
Closes facebook/react-native#13003

Differential Revision: D4731566

Pulled By: hramos

fbshipit-source-id: 62562536db7589a03a511762117cbf0e36d3aafb
facebook-github-bot pushed a commit that referenced this pull request Mar 18, 2017
@cooperka @facebook-github-bot
Fix suggestion to "npm start -- --reset-cache"
06dd083 
Summary:
As discussed in #11983. The double dash is necessary to pass through the argument to node. Based on the comments [here](#1924 (comment)), it looks like most people use the double dash; it's unclear whether it would do anything at all if the dashes were omitted. If anyone else has better insight, let me know!
Closes #13003

Differential Revision: D4731566

Pulled By: hramos

fbshipit-source-id: 62562536db7589a03a511762117cbf0e36d3aafb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radko93 @facebook-github-bot @cooperka @hramos