[RCTBridge] Have RCTBridge.loading return RCTBatchedBridge.loading #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
The parent RCTBridge no longer tracks the JS loading since that has been handed off to the RCTBatchedBridge. To make the `loading` property accurate again, just expose the batch bridge's loading property from the parent bridge (note: I didn't make it KVO-compliant).
|
The reason some methods and properties were removed from the parent bridge is because I don't think they should be accessed from the top level. I might not be considering some use case though, can you explain yours? |
|
I use them for assertions when creating an RCTBridge and loading JS but would be OK with moving the property out of RCTBridge.h and into the RCTBatchedBridge |
|
@tadeuzagallo it seems like loading should be exposed on the parent bridge anyway, as it doesn't suffer from concurrency issues. |
ayushjainrksh
pushed a commit
to MLH-Fellowship/react-native
that referenced
this pull request
Jul 2, 2020
acoates-ms
pushed a commit
to acoates-ms/react-native
that referenced
this pull request
Jun 22, 2022
Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/chalk/ansi-regex/releases) - [Commits](chalk/ansi-regex@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: ansi-regex dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parent RCTBridge no longer tracks the JS loading since that has been handed off to the RCTBatchedBridge. To make the
loadingproperty accurate again, just expose the batch bridge's loading property from the parent bridge (note: I didn't make it KVO-compliant).Fixes #1199