Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[package.json] Leave the protocol choice for a Github repo to npm #1447

Closed
wants to merge 2 commits into from
Closed

[package.json] Leave the protocol choice for a Github repo to npm #1447

wants to merge 2 commits into from

Conversation

brentvatne
Copy link
Collaborator

Fixes #1371

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels May 29, 2015
@@ -61,7 +61,7 @@
"rebound": "^0.0.12",
"sane": "git://github.com/tadeuzagallo/sane.git#a029f8b04a",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this also be updated then?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks for catching that

@frantic
Copy link
Contributor

frantic commented Jun 1, 2015

Landed internally, should be here with the next sync. Thanks for fixing it, @brentvatne!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm install --save react-native failed
3 participants