Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react@16 did away with PropTypes; require prop-types instead #14641

Closed
wants to merge 2 commits into from
Closed

react@16 did away with PropTypes; require prop-types instead #14641

wants to merge 2 commits into from

Conversation

mojodna
Copy link
Contributor

@mojodna mojodna commented Jun 20, 2017

react@16 (a peerDependency) did away with the PropTypes export in favor of the prop-types module.

This updates all of the remaining references to React.PropTypes.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 20, 2017
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gmaclennan
Copy link

Fixes #14588

@chirag04
Copy link
Contributor

@facebook-github-bot shipit

@chirag04 chirag04 requested a review from hramos June 20, 2017 21:17
@facebook-github-bot
Copy link
Contributor

@chirag04 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@hramos hramos mentioned this pull request Jun 22, 2017
Closed
lex111 referenced this pull request in ovr/ghubber Jun 22, 2017
@ovr
NPM: Update all deps
83ee508
@facebook-github-bot facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels Jun 22, 2017
@facebook-github-bot
Copy link
Contributor

@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

alexparish pushed a commit to alexparish/react-native that referenced this pull request Jun 24, 2017
@mojodna
react@16 did away with PropTypes; require prop-types instead
e94ae2b 
Summary:
react@16 (a peerDependency) did away with the PropTypes export in favor of the prop-types module.

This updates all of the remaining references to `React.PropTypes`.
Closes facebook#14641

Differential Revision: D5287167

Pulled By: javache

fbshipit-source-id: a917e29aa0e5470260568995dfe97f5528ec265e
@mojodna mojodna deleted the prop-types branch June 26, 2017 18:20
grabbou pushed a commit that referenced this pull request Jul 5, 2017
@mojodna @grabbou
react@16 did away with PropTypes; require prop-types instead
dee6aab 
Summary:
react@16 (a peerDependency) did away with the PropTypes export in favor of the prop-types module.

This updates all of the remaining references to `React.PropTypes`.
Closes #14641

Differential Revision: D5287167

Pulled By: javache

fbshipit-source-id: a917e29aa0e5470260568995dfe97f5528ec265e
@ohir ohir mentioned this pull request Jul 9, 2017
Closed
hramos pushed a commit that referenced this pull request Jul 12, 2017
@mojodna @hramos
react@16 did away with PropTypes; require prop-types instead
02a1eda 
Summary:
react@16 (a peerDependency) did away with the PropTypes export in favor of the prop-types module.

This updates all of the remaining references to `React.PropTypes`.
Closes #14641

Differential Revision: D5287167

Pulled By: javache

fbshipit-source-id: a917e29aa0e5470260568995dfe97f5528ec265e
hramos pushed a commit that referenced this pull request Jul 12, 2017
@mojodna @hramos
react@16 did away with PropTypes; require prop-types instead
e76eb32 
Summary:
react@16 (a peerDependency) did away with the PropTypes export in favor of the prop-types module.

This updates all of the remaining references to `React.PropTypes`.
Closes #14641

Differential Revision: D5287167

Pulled By: javache

fbshipit-source-id: a917e29aa0e5470260568995dfe97f5528ec265e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mojodna @facebook-github-bot @gmaclennan @chirag04 @hramos @javache