Set constructor properly in createReactNativeComponentClass #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the displayName property wasn't found when looking at `.constructor` on a component instance. Fixes facebook/react-devtools#92.
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@brentvatne: in order to get things to the rc, we have to go through fb internal cherry-pick process and i don't think this is worth it. The goal of the rc is to be as stable as possible and only cherry-pick bug fixes. Cherry-picking features like this makes it harder to figure out what is available in what version. 2 weeks is short enough that we can wait for the next version to get those safely |
|
This is also not a regression (AFAIK) so that's another reason it can wait. |
|
Sounds good, thanks for the clarification |
ayushjainrksh
pushed a commit
to MLH-Fellowship/react-native
that referenced
this pull request
Jul 2, 2020
* Uses `eventValue` not `value` * Running prettier on the modified JS
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the displayName property wasn't found when looking at
.constructoron a component instance. Fixes facebook/react-devtools#92.