Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes the error thrown by setting responseType after a request has … #14992

Closed
wants to merge 2 commits into from
Closed

Removes the error thrown by setting responseType after a request has … #14992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd510bd
Removes the error thrown by setting responseType after a request has …
Jul 13, 2017
b17cf23
Merge branch 'master' into fix-xmlhttprequest-responsetype-exception
beau6183 Jul 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Libraries/Network/XMLHttpRequest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,12 +175,6 @@ class XMLHttpRequest extends EventTarget(...XHR_EVENTS) {
}

set responseType(responseType: ResponseType): void {
if (this._sent) {
throw new Error(
'Failed to set the \'responseType\' property on \'XMLHttpRequest\': The ' +
'response type cannot be set after the request has been sent.'
);
}
if (!SUPPORTED_RESPONSE_TYPES.hasOwnProperty(responseType)) {
warning(
false,
Expand Down
5 changes: 0 additions & 5 deletions Libraries/Network/__tests__/XMLHttpRequest-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,6 @@ describe('XMLHttpRequest', function() {

xhr.responseType = 'arraybuffer';
expect(xhr.responseType).toBe('arraybuffer');

// Can't change responseType after first data has been received.
xhr.open('GET', 'blabla');
xhr.send();
expect(() => { xhr.responseType = 'text'; }).toThrow();
});

it('should expose responseText correctly', function() {
Expand Down