Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve docs for KeyboardAvoidingView #16479

Closed
wants to merge 2 commits into from
Closed

improve docs for KeyboardAvoidingView #16479

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6065eea
improve docs for KeyboardAvoidingView
gwmccull Oct 20, 2017
09874b5
update verbiage on docs and rename internal component functions to hi…
gwmccull Oct 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Libraries/Components/Keyboard/KeyboardAvoidingView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,15 +43,19 @@ type KeyboardChangeEvent = {
const viewRef = 'VIEW';

/**
* It is a component to solve the common problem of views that need to move out of the way of the virtual keyboard.
* It can automatically adjust either its position or bottom padding based on the position of the keyboard.
* This is a component to solve the common problem of views that need to move out of the way of the virtual keyboard.
* It can automatically adjust either its height, position or bottom padding based on the position of the keyboard.
*/
const KeyboardAvoidingView = createReactClass({
displayName: 'KeyboardAvoidingView',
mixins: [TimerMixin],

propTypes: {
...ViewPropTypes,
/**
* Specify how the `KeyboardAvoidingView` will react to the presence of
* the keyboard. Will it adjust its height, position or bottom padding?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you phrase this not as a question. Something like "Specify if it will adjust ..."

*/
behavior: PropTypes.oneOf(['height', 'position', 'padding']),

/**
Expand All @@ -61,7 +65,7 @@ const KeyboardAvoidingView = createReactClass({

/**
* This is the distance between the top of the user screen and the react native view,
* may be non-zero in some use cases.
* may be non-zero in some use cases. The default value is 0.
*/
keyboardVerticalOffset: PropTypes.number.isRequired,
},
Expand Down