Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for iOS static bundle #16551

Closed
wants to merge 1 commit into from

Conversation

emusgrave
Copy link

Motivation

Include instructions on how to use the static bundle when building an iOS App for production. Also include tips to document the SKIP_BUNDLING flag that was recently added, as well as fix the white background flash when the bundle size is large.

There are a number of issues and past pull requests that tackle this same problem but no one has properly updated the documentation to reflect the conclusions that have been made:
#240
Updates #625
Also Refers to #1402

Test Plan

Build an app for production using a Release scheme in Xcode, and see that it does not require the React Native Packager to be running.

Release Notes

[DOCS][ENHANCEMENT][docs/RunningOnDevice.md] - Document how to use a static bundle for iOS

Include instructions on how to use the static bundle when building an iOS App for production. Also include tips to document the SKIP_BUNDLING flag that was recently added, as well as fix the white background flash when the bundle size is large.
@emusgrave emusgrave requested a review from hramos as a code owner October 26, 2017 14:46
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 26, 2017
@pull-bot
Copy link

Messages
📖

📄 Docs - Thanks for your contribution to the docs!

@facebook-github-bot label Documentation

Attention: @hramos

Generated by 🚫 dangerJS

@facebook-github-bot
Copy link
Contributor

@emusgrave I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

@hramos
Copy link
Contributor

hramos commented Dec 8, 2017

Thanks for the contribution. The docs have moved to their own repo at facebook/react-native-website. I've applied your change over there.

@hramos hramos closed this Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants