[Testing] [Docker] Update image #17325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebuilding should be rarely needed, but in this case we did need a newer BUCK version
facebook-github-bot
added
CLA Signed
facebook-github-bot
approved these changes
Dec 22, 2017
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
mathiasbynens
pushed a commit
to mathiasbynens/react-native
that referenced
this pull request
Jan 13, 2018
Summary: Use newer Docker image and add script that rebuilds the image locally Rebuilding should be rarely needed, but in this case we did need a newer BUCK version To run tests locally: ``` npm run test-android-setup npm run test-android-build npm run test-android-run-unit-test ``` If a newer android-base image is needed, just run `npm run test-android-build-base` to rebuild the image locally. Ping hramos if the Docker hub image is too out of date. Closes facebook#17325 Differential Revision: D6630793 Pulled By: hramos fbshipit-source-id: ec76ec86aec0debf914649b7ec5fdafccf28fec7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use newer Docker image and add script that rebuilds the image locally
Rebuilding should be rarely needed, but in this case we did need a newer BUCK version
To run tests locally:
If a newer android-base image is needed, just run
npm run test-android-build-baseto rebuild the image locally. Ping @hramos if the Docker hub image is too out of date.