Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6228: Crash in Android dialog module. #17392

Closed
wants to merge 1 commit into from
Closed

Fix #6228: Crash in Android dialog module. #17392

wants to merge 1 commit into from

Commits on Dec 29, 2017

  1. Android dialog module has a race condition as result it crashes see t… 

    …his issue:

facebook#6228.

The mIsInForeground flag is set on UI thread but was used from the ReactMethod thread.
I added asserts to make sure that FragmentManagerHelper wouldn't be used incorrectly.

Make sure that dialogs work after this change.
It will be nearly impossible to reproduce the issue manually but automatic regression tests should be able to catch this. At least our tests are crashing on some dialog scenarios from time to time.

[ANDROID] [MINOR] [BUGFIX] - Race condition fix for Dialogs module.
    @dryganets
    dryganets committed Dec 29, 2017
    Configuration menu
    Copy the full SHA
    c7210b0 View commit details
    Browse the repository at this point in the history