Android WebView Bugfix: loadUrl() ignores default encoding #17394
Conversation
Closes facebook#17385 The loadUrl() method ignores the default encoding on Android KitKat.
facebook-github-bot
added
the
CLA Signed
|
@adrianomelo I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
react-native-bot
added
Android
Ran Commands
react-native-bot
added
Platform: Android
|
WebView PRs are on hold pending approval of the WebView proposal at react-native-community/discussions-and-proposals#3 |
|
WebViews have now been moved to react-native-community/react-native-webview. Would you like to relaunch this PR there? I'm sure the maintainers would love your contribution. 🙂 |
Closes #17385
The loadUrl() method ignores the default encoding on Android KitKat.
Motivation
I manage to reproduce the issue described by #17385 using Android KitKat (emulator).
Test Plan
I tested by modifying the RNTester project with the changes below. I have tested on Android KitKat (emulator) and Android Oreo 8.1 (device - Nexus 6p).
<html> <head> <title>Hello Static World</title> - <meta http-equiv="content-type" content="text/html; charset=utf-8"> <meta name="viewport" content="width=320, user-scalable=no"> <style type="text/css"> body { @@ -391,7 +390,7 @@ const HTML = ` </style> </head> <body> - <h1>Hello Static World</h1> + <h1>Hello Static World olá</h1> </body> </html>Release Notes
[ANDROID] [BUGFIX] [WebView] - Default encoding for html content on older Android versions