Fix for 17348 #17463
Fix for 17348 #17463
Conversation
Fixes facebook#17348 - Unhandled JS Exception: TypeError: undefined is not an object (evaluating 'this._subscribableSubscriptions.forEach')
|
@facebook-github-bot label iOS Generated by 🚫 dangerJS |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
@facebook-github-bot CLA signed |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@iMagdy I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
There was a problem hiding this comment.
@TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@TheSavior What's the status on this? |
|
@iMagdy, landed! Thanks for contributing! |
|
@TheSavior Thanks! |
Fixes #17348 - Unhandled JS Exception: TypeError: undefined is not an object (evaluating 'this._subscribableSubscriptions.forEach')
Test Plan
Same existing tests applies, just added extra checks.
Release Notes
This patch fixes the issue #17348
[ANDROID] [BUGFIX] [Subscribable] - Fix for #17348
[IOS] [BUGFIX] [Subscribable] - Fix for #17348