[Bridge] Support nullability annotations in bridged methods #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a crash due to the selector regex not knowing about the nullability annotations. Adds support for both the core annotations `__nullable` and `__nonnull` plus their shorthand counterparts `nullable` and `nonnull`.
Objective-C allows the shorthand versions only at the front of a parameter type declaration like `(nullable NSString *)` but the regex will pick up `(NSString * nullable)` too. This shouldn't cause any adverse effects and I left the code this way to keep the regex readable.
Test Plan: Write a bridge method that uses a nullability annotation and verified that it didn't cause the app to crash:
```
RCT_EXPORT_METHOD(method:(nullable NSNumber *)reactTag)
{
}
```
Also added a nullable annotation to RCTTest.
facebook-github-bot
added
the
CLA Signed
|
Thanks, I've been meaning to add this (along with typed collections/generics support). What would be really cool though, is if the bridge enforced this by checking for NSNull values for nonnull arguments and threw a redbox. Do you think it's feasible to add that to this PR, or would you prefer I land this as-is and create a new task? |
|
Could you land this diff separately? Thinking about generics, there's a fair bit of overlap in the bookkeeping for nullability annotations and generics so it might make sense to plan for both features together. |
|
👍🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash due to the selector regex not knowing about the nullability annotations. Adds support for both the core annotations
__nullableand__nonnullplus their shorthand counterpartsnullableandnonnull.Objective-C allows the shorthand versions only at the front of a parameter type declaration like
(nullable NSString *)but the regex will pick up(NSString * nullable)too. This shouldn't cause any adverse effects and I left the code this way to keep the regex readable.Fixes #1795
Test Plan: Wrote a bridge method that uses a nullability annotation and verified that it didn't cause the app to crash:
Also added a nullable annotation to RCTTest.