fix undefined_arch error in Xcode 10 beta #19841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
react-native-bot
added
✅Test Plan
Type: Enhancement
facebook-github-bot
added
the
CLA Signed
everything that runs iOS 8 should be supported so we cannot use arm64. arm64 is backward compatible with armv7
hramos
suggested changes
Jun 25, 2018
|
I've applied this patch to a clean checkout of If |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jun 25, 2018
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
All green, landing. |
hramos
pushed a commit
that referenced
this pull request
Jul 4, 2018
Summary: Fixes #19774 I spotted that in Xcode 10 beta `CURRENT_ARCH` is set to string `undefined_arch`. This PR will add fallback based on platform name (simulators are `x86_64` and everything since iPhone 5s is `arm64`). Closes #19841 Differential Revision: D8619897 Pulled By: hramos fbshipit-source-id: ed2ebaca105c6dcb40099f1a4aebe34d0660130c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19774
I spotted that in Xcode 10 beta
CURRENT_ARCHis set to stringundefined_arch. This PR will add fallback based on platform name (simulators arex86_64and everything since iPhone 5s isarm64).Test Plan:
Try to build on Xcode 10 beta - build will pass without issues.
Check if it works on Xcode 9 - build will pass as well.
Release Notes:
[IOS][INTERNAL] [ENHANCEMENT] [./scripts/ios-configure-glog.sh] - fix undefined_arch error in Xcode 10 beta