Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add windows ci #20281

Closed
wants to merge 8 commits into from
Closed

Conversation

gengjiawen
Copy link
Contributor

@gengjiawen gengjiawen commented Jul 18, 2018

Motivation

Build status
Add windows ci

Test Plan

pass all current ci.

Related PRs

none

Release Notes

[GENERAL] [INTERNAL] [CI] - add windows ci

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2018
@react-native-bot react-native-bot added ✅Test Plan Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels Jul 18, 2018
@gengjiawen gengjiawen changed the title [WIP]add windows ci add windows ci Jul 18, 2018
@gengjiawen
Copy link
Contributor Author

cc @hramos

appveyor.yml Outdated
- sdkmanager "extras;android;m2repository"

- ps: Install-Product node $env:nodejs_version
- npm install
Copy link
Contributor

@matthargett matthargett Jul 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest doing appveyor-retry npm to make it resilient against intermittent network issues. I added this in the react-native-windows AppVeyor configuration to eliminate a not-uncommon source of flakiness. https://github.com/Microsoft/react-native-windows/blob/master/appveyor.yml#L40

You may also want to add appveyor-retry npm install npm@lts as the first command. We also did that to combat flakiness around the npm 5 era.

@matthargett
Copy link
Contributor

Right now, the build doesn't get to npm test -- it fails on the gradle command, with the failure indicator saying :RNTester:android:app:bundleReleaseJsAndAssets FAILED.

Is that what we expect? Can we up the logging level so the error is more detailed and easier for users without a local Windows instance to reason about?

@matthargett
Copy link
Contributor

I love how clean this is with things extracted into variables, btw. Great job! 🥇

@hramos hramos added Core Team 🔩Test Infrastructure Test infrastructure and continuous integration. and removed Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. labels Jul 18, 2018
@gengjiawen
Copy link
Contributor Author

The failure is expected, since the windows issue still exists. Hopefully @rafeca can fix facebook/metro#181 today. The gradle error message in most case in sufficient.

@gengjiawen
Copy link
Contributor Author

@hramos Can you enable appveyor for react native, I want to add the badge in README.md.

@hramos
Copy link
Contributor

hramos commented Jul 19, 2018

Enabled.

@gengjiawen gengjiawen requested a review from hramos as a code owner July 19, 2018 14:01
@gengjiawen
Copy link
Contributor Author

@hramos I have updated README.md. Do you plan to merge this or after have the windows build fixed ?

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jul 19, 2018
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was closed by @gengjiawen in 1b2a552.

Once this commit is added to a release, you will see the corresponding version tag below the description at 1b2a552. If the commit has a single master tag, it is not yet part of a release.

@facebook facebook locked as resolved and limited conversation to collaborators Jul 19, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Jul 19, 2018
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. 🔩Test Infrastructure Test infrastructure and continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants