Fix TextInput shadow props not update when setText on iOS

[zhongwuzw]

Fixes #20224

Test Plan:

The code as below, click TouchableOpacity, click textInput , edit text, then click TouchableOpacity again.

import React from "react";
import { View, Text, TextInput, TouchableOpacity } from "react-native";

export default class App extends React.Component {
  state = {
    isReactNative: true
  };

  insertText = () => {
    this.textInput.setNativeProps({ text: "ReactNative" });
  };

  render() {
    return (
      <View style={{ paddingTop: 128, alignItems: "center" }}>
        <TextInput
          style={{
            width: "100%",
            backgroundColor: "#ccc",
            fontSize: 48,
            textAlign: "center"
          }}
          ref={ref => {
            this.textInput = ref;
          }}
        />

        <TouchableOpacity style={{ padding: 16 }} onPress={this.insertText}>
          <Text style={{ fontSize: 24 }}>Insert ReactNative</Text>
        </TouchableOpacity>
      </View>
    );
  }
}

Release Notes:

[IOS] [BUGFIX] [TextInput] - Fix TextInput shadow props not update when update local data.

[pull-bot]

	Warnings
⚠️	📋 Release Notes - This PR appears to be missing Release Notes.

Generated by 🚫 dangerJS

[facebook-github-bot]

hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[hramos]

This does not appear to be the root cause of the bug. Can you explain the reasoning behind adding this line?

It seems like the actual bug would originate in RCTBaseTextInputView.m.

[zhongwuzw]

@hramos Emm, I think it's not the cause from RCTBaseTextInputView.m. because we only call it when we compare it wether changed in shadow view. And because we don't update the text of RCTBaseTextInputShadowView, leads to wrong comparison.

[cpojer]

What's the status of this PR?

[shergin]

_text represents the actual prop value, changing that not from JS does not seem right to me.

Why does this change fix the issue?

[zhongwuzw]

I'll closing this because the issue already fixes.