Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StatusBar] Add ability to toggle the network activity indicator in the status bar + example in UIExplorer #2079

Conversation

negativetwelve
Copy link
Contributor

Added the ability to turn on and off the network activity indicator using:

StatusBarIOS.setNetworkActivityIndicatorVisible(true)

and

StatusBarIOS.setNetworkActivityIndicatorVisible(false)

Also added an example to the UIExplorer example app.

Fix #986

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 21, 2015
@negativetwelve
Copy link
Contributor Author

I don't think this test is related to my change, but can someone familiar with the UIExplorer tests shed some light here, would really appreciate it, thanks!

    ✗ -[RCTAllocationTests testContentViewIsInvalidated] (238 ms) (0)

@frantic frantic self-assigned this Jul 23, 2015
@frantic
Copy link
Contributor

frantic commented Jul 23, 2015

👍 thanks!

@frantic
Copy link
Contributor

frantic commented Jul 23, 2015

@facebook-github-bot import

1 similar comment
@vjeux
Copy link
Contributor

vjeux commented Jul 23, 2015

@facebook-github-bot import

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1525113294408758/int_phab to review.

1 similar comment
@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1525113294408758/int_phab to review.

@frantic frantic closed this in 10ffe17 Jul 27, 2015
ptmt pushed a commit to ptmt/react-native that referenced this pull request Jul 28, 2015
…he status bar + example in UIExplorer

Summary:
Added the ability to turn on and off the network activity indicator using:

```
StatusBarIOS.setNetworkActivityIndicatorVisible(true)
```
and
```
StatusBarIOS.setNetworkActivityIndicatorVisible(false)
```

Also added an example to the UIExplorer example app.

Fix facebook#986
Closes facebook#2079
Github Author: Mark Miyashita <negativetwelve@gmail.com>
@negativetwelve negativetwelve deleted the status-bar/network-indicator branch April 11, 2016 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants