-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prettify remaining unprettified files #21327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eslint
found some issues. You may run yarn prettier
or npm run prettier
to fix these.
}]} | ||
style={[ | ||
styles.base, | ||
styles.leftMargin, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
react-native/no-inline-styles: Inline style: { borderWidth: 10,
borderTopLeftRadius: 10,
borderBottomRightRadius: 20,
borderColor: 'green' }
}]} | ||
style={[ | ||
styles.base, | ||
styles.leftMargin, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
react-native/no-inline-styles: Inline style: { borderWidth: 5,
borderTopLeftRadius: 10,
borderTopRightRadius: 20,
borderBottomRightRadius: 30,
borderBottomLeftRadius: 40,
borderColor: 'red' }
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@empyrical merged commit 2da60a8 into Once this commit is added to a release, you will see the corresponding version tag below the description at 2da60a8. If the commit has a single |
Summary: This PR is the result of running `yarn prettify` on the codebase - which caught a few files that were not prettified. This will make instructing people to run prettify a bit less complicated, since unrelated files will not show up in diffs. Pull Request resolved: facebook/react-native#21327 Differential Revision: D10046057 Pulled By: TheSavior fbshipit-source-id: 2c771a3c758c72816c707e32ee2f4587e466f277
Summary: This PR is the result of running `yarn prettify` on the codebase - which caught a few files that were not prettified. This will make instructing people to run prettify a bit less complicated, since unrelated files will not show up in diffs. Pull Request resolved: facebook/react-native#21327 Differential Revision: D10046057 Pulled By: TheSavior fbshipit-source-id: 2c771a3c758c72816c707e32ee2f4587e466f277
Summary: This PR is the result of running `yarn prettify` on the codebase - which caught a few files that were not prettified. This will make instructing people to run prettify a bit less complicated, since unrelated files will not show up in diffs. Pull Request resolved: facebook#21327 Differential Revision: D10046057 Pulled By: TheSavior fbshipit-source-id: 2c771a3c758c72816c707e32ee2f4587e466f277
This PR is the result of running
yarn prettify
on the codebase - which caught a few files that were not prettified. This will make instructing people to run prettify a bit less complicated, since unrelated files will not show up in diffs.Test Plan:
No behaviour was changed.
Release Notes:
Help reviewers and the release process by writing your own release notes. See below for an example.
[GENERAL] [MINOR] [Libraries/Components/ScrollView/ScrollView.js] - Prettified
[GENERAL] [MINOR] [Libraries/Components/TextInput/TextInput.js] - Prettified
[GENERAL] [MINOR] [Libraries/Image/Image.ios.js] - Prettified
[GENERAL] [MINOR] [RNTester/js/ImageExample.js] - Prettified
[GENERAL] [MINOR] [flow/jest.js] - Prettified
[GENERAL] [MINOR] [local-cli/bundle/tests/getAssetDestPathAndroid-test.js] - Prettified
[GENERAL] [MINOR] [local-cli/bundle/tests/getAssetDestPathIOS-test.js] - Prettified
[GENERAL] [MINOR] [local-cli/generator/templates.js] - Prettified
[GENERAL] [MINOR] [local-cli/init/init.js] - Prettified