Rounded corner rendering fixed on Android N. #21340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
dryganets
commented
Sep 26, 2018
| @@ -241,8 +241,7 @@ public void setBorderRadius(float borderRadius) { | |||
| ReactViewBackgroundDrawable backgroundDrawable = getOrCreateReactViewBackground(); | |||
| backgroundDrawable.setRadius(borderRadius); | |||
|
|
|||
| if (Build.VERSION_CODES.HONEYCOMB < Build.VERSION.SDK_INT | |||
There was a problem hiding this comment.
You don't support targets below HONEYCOMB anyway. The only API level affected by the original check was 16.
Generated by 🚫 dangerJS |
react-native-bot
added
Platform: Android
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 27, 2018
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@dryganets merged commit 748cf82 into Once this commit is added to a release, you will see the corresponding version tag below the description at 748cf82. If the commit has a single |
grabbou
pushed a commit
that referenced
this pull request
Oct 2, 2018
Summary: On Android N (API 24) rounded corners rendering has issues in case scale factor is set for the view. Pull Request resolved: #21340 Differential Revision: D10084318 Pulled By: hramos fbshipit-source-id: 53ae5a32b96cc7ee7eba084330682239d8beb85d
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: On Android N (API 24) rounded corners rendering has issues in case scale factor is set for the view. Pull Request resolved: facebook#21340 Differential Revision: D10084318 Pulled By: hramos fbshipit-source-id: 53ae5a32b96cc7ee7eba084330682239d8beb85d
elicwhite
added
p: Microsoft
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android N (API 24) rounded corners rendering has issues in case scale factor is set for the view.
Test Plan:
Setup transform scale not equal 1.0 for view with rounded corners. On Android 7.0 view will be incorrectly positioned in case hardware optimization is turned on.
Release Notes:
[Android] [UI] [View] - Rounded corner rendering fixed on android 7.0.