-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PropTypes from IncrementalPresenter #21343
Conversation
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Thanks for the PR.
There are a few quick tweaks that should be made to this -
The props should be made read-only and exact, like this:
type Props = $ReadOnly<{|
//...
|}>;
The callbacks should be cleaned up, so that their return type is mixed
rather than void
.
The type for event
on onLayout
should also be LayoutEvent
, which you can import from:
import type {LayoutEvent} from 'CoreEventTypes';
You also need to add children as a type to Props
:
children?: React.Node,
Just did the request changes, @empyrical. Thanks for the advise. |
Looks like there's a flow failure here:
This is because the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TheSavior has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@julioxavierr merged commit 0625c34 into Once this commit is added to a release, you will see the corresponding version tag below the description at 0625c34. If the commit has a single |
Thanks for contributing! |
Summary: Related to facebook#21342 Pull Request resolved: facebook#21343 Reviewed By: RSNara Differential Revision: D10080219 Pulled By: TheSavior fbshipit-source-id: 3a9108208fe6aaa7a30b99f24ceef03e884ec48a
Related to #21342