[createReactClass] Removing createReactClass from ListView*Example.js #21582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
exced
changed the title
RSNara
changed the title
RSNara
approved these changes
Oct 9, 2018
| title: '<ListView> - Grid Layout', | ||
| description: 'Flexbox grid layout.', | ||
| }, | ||
| class ListViewGridLayoutExample extends React.Component<{}, State> { |
There was a problem hiding this comment.
Can we use RNTesterProps here as well?
There was a problem hiding this comment.
RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@RSNara I pushed the RNTesterProps update |
There was a problem hiding this comment.
RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
added
the
Import Started
hramos
removed
Import Started
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Apr 14, 2019
Summary: Related to #21581 Remove createReactClass from ListViewExample and ListViewGridLayoutExample - All flow tests succeed. - Run RNTester app, go to ListView component, scroll, expand rows, everything works. - Run RNTester app, go to ListViewGridLayout component, scroll, click on icons, everything works. [GENERAL] [ENHANCEMENT] [ListViewExample.js] - rm createReactClass [GENERAL] [ENHANCEMENT] [ListViewGridLayoutExample.js] - rm createReactClass Pull Request resolved: facebook/react-native#21582 Differential Revision: D10274350 Pulled By: RSNara fbshipit-source-id: 4ea505a0f9661300309d6b9457202085293333b5
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Related to facebook#21581 Remove createReactClass from ListViewExample and ListViewGridLayoutExample - All flow tests succeed. - Run RNTester app, go to ListView component, scroll, expand rows, everything works. - Run RNTester app, go to ListViewGridLayout component, scroll, click on icons, everything works. [GENERAL] [ENHANCEMENT] [ListViewExample.js] - rm createReactClass [GENERAL] [ENHANCEMENT] [ListViewGridLayoutExample.js] - rm createReactClass Pull Request resolved: facebook#21582 Differential Revision: D10274350 Pulled By: RSNara fbshipit-source-id: 4ea505a0f9661300309d6b9457202085293333b5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #21581
Remove createReactClass from ListViewExample and ListViewGridLayoutExample
Test Plan:
Release Notes:
[GENERAL] [ENHANCEMENT] [ListViewExample.js] - rm createReactClass
[GENERAL] [ENHANCEMENT] [ListViewGridLayoutExample.js] - rm createReactClass