-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[createReactClass] remove createReactClass from the RNTester/js/TextExample.ios.js #21603
[createReactClass] remove createReactClass from the RNTester/js/TextExample.ios.js #21603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! 😁
var {Text, TextInput, View, LayoutAnimation, Button} = ReactNative; | ||
const React = require('react'); | ||
const ReactNative = require('react-native'); | ||
const {Text, TextInput, View, LayoutAnimation, Button} = ReactNative; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
|}; | ||
|
||
class AdjustingFontSize extends React.Component<{}, AdjustingFontSizeState> { | ||
static displayName: ?string = 'AdjustingFontSize'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, no need for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@nd-02110114 merged commit 5512c47 into |
Summary: Related to #21581 . Removed createReactClass from the RNTester/js/TextExample.ios.js - [x] npm run prettier - [x] npm run flow-check-ios - [x] npm run flow-check-android [GENERAL] [ENHANCEMENT] [RNTester/js/TextExample.ios.js] - remove createReactClass dependency Pull Request resolved: facebook/react-native#21603 Differential Revision: D10260872 Pulled By: RSNara fbshipit-source-id: f63476756a10ddbce04da901012247d028579d53
…book#21603) Summary: Related to facebook#21581 . Removed createReactClass from the RNTester/js/TextExample.ios.js - [x] npm run prettier - [x] npm run flow-check-ios - [x] npm run flow-check-android [GENERAL] [ENHANCEMENT] [RNTester/js/TextExample.ios.js] - remove createReactClass dependency Pull Request resolved: facebook#21603 Differential Revision: D10260872 Pulled By: RSNara fbshipit-source-id: f63476756a10ddbce04da901012247d028579d53
Related to #21581 .
Removed createReactClass from the RNTester/js/TextExample.ios.js
Test Plan
Release Notes
[GENERAL] [ENHANCEMENT] [RNTester/js/TextExample.ios.js] - remove createReactClass dependency