Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[createReactClass] remove createrReactClass from SizeFlexibilityUpdateTest #21715

Conversation

nissy-dev
Copy link
Contributor

Related to #21581 .
Removed createReactClass from the IntegrationTests/SizeFlexibilityUpdateTest.js

Test Plan

  • npm run prettier
  • npm run flow-check-ios
  • npm run flow-check-android

Release Notes

[GENERAL] [ENHANCEMENT] [IntegrationTests/SizeFlexibilityUpdateTest.js] - remove createReactClass dependency

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 11, 2018
Copy link
Contributor

@RSNara RSNara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@nd-02110114 merged commit bb6a690 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Oct 16, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 16, 2018
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
Summary:
Related to facebook#21581 .
Removed createReactClass from the IntegrationTests/SizeFlexibilityUpdateTest.js

 - [x] npm run prettier
 - [x] npm run flow-check-ios
 - [x] npm run flow-check-android

[GENERAL] [ENHANCEMENT] [IntegrationTests/SizeFlexibilityUpdateTest.js] - remove createReactClass dependency
Pull Request resolved: facebook#21715

Reviewed By: TheSavior

Differential Revision: D10341543

Pulled By: RSNara

fbshipit-source-id: 748f9a0176b6cd865d956df774f6dec1ead21562
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants