-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jsc regression.Fixes #22274 #22293
Conversation
@@ -324,7 +324,7 @@ dependencies { | |||
api "com.squareup.okhttp3:okhttp:${OKHTTP_VERSION}" | |||
api "com.squareup.okhttp3:okhttp-urlconnection:${OKHTTP_VERSION}" | |||
api 'com.squareup.okio:okio:1.14.0' | |||
compile project(':android-jsc') | |||
compile 'org.webkit:android-jsc:r174650' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing my reported issue.
@Kudo Thanks for report and review this. |
@facebook-github-bot shipit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kelset is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@gengjiawen merged commit f22473e into |
Summary: My silly mistake when tinkering with the jsc lib. Also you have this patch first #22295. Kudo plz review. ![image](https://user-images.githubusercontent.com/3759816/48561684-758f6f00-e92b-11e8-905b-e394f72349f7.png) Pull Request resolved: #22293 Differential Revision: D13153931 Pulled By: hramos fbshipit-source-id: 8a6efa0cd8abbff359f082d5ea7713933b6e7ac6
Summary: My silly mistake when tinkering with the jsc lib. Also you have this patch first facebook#22295. Kudo plz review. ![image](https://user-images.githubusercontent.com/3759816/48561684-758f6f00-e92b-11e8-905b-e394f72349f7.png) Pull Request resolved: facebook#22293 Differential Revision: D13153931 Pulled By: hramos fbshipit-source-id: 8a6efa0cd8abbff359f082d5ea7713933b6e7ac6
Summary: My silly mistake when tinkering with the jsc lib. Also you have this patch first facebook#22295. Kudo plz review. ![image](https://user-images.githubusercontent.com/3759816/48561684-758f6f00-e92b-11e8-905b-e394f72349f7.png) Pull Request resolved: facebook#22293 Differential Revision: D13153931 Pulled By: hramos fbshipit-source-id: 8a6efa0cd8abbff359f082d5ea7713933b6e7ac6
My silly mistake when tinkering with the jsc lib. Also you have this patch first #22295.
@Kudo plz review.