Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Changelog instead of Release Notes for danger bot #22395

Closed

Conversation

radko93
Copy link
Contributor

@radko93 radko93 commented Nov 23, 2018

In #22117 we changed the PR template to use Changelog instead of Release notes and now danger bot is complaining as it wasn't updated there.

cc @turnrye

Test Plan:

No test plan needed.
(It actually complained about wrong changelog so it's working 👍 )

Changelog:

Not a user-facing changes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 23, 2018
@pull-bot
Copy link

Warnings
⚠️

📋 Changelog - This PR may have incorrectly formatted Changelog.

Generated by 🚫 dangerJS

@kelset
Copy link
Contributor

kelset commented Nov 26, 2018

cc @turnrye @TheSavior

Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • eslint found some issues.

bots/dangerfile.js Show resolved Hide resolved
@turnrye
Copy link
Contributor

turnrye commented Nov 26, 2018

LGTM

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Nov 26, 2018
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kelset is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@elicwhite
Copy link
Member

This has failed to land because eslint is failing:

$ eslint .
/tmp/react-native-fPb3adIG/react-native-github/bots/dangerfile.js
  46:57  error  Replace `⏎··danger.github.pr.body,⏎` with `danger.github.pr.body`  prettier/prettier

We should fix this, but also why is this not failing in the Circle CI checks? cc @hramos

@facebook-github-bot facebook-github-bot added Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Nov 26, 2018
@facebook-github-bot
Copy link
Contributor

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

@radko93
Copy link
Contributor Author

radko93 commented Nov 27, 2018

@TheSavior I updated the PR. It's actually failing on Circle CI but the build is passing anyway.

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Nov 27, 2018
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@radko93 merged commit 706888d into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Nov 27, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Nov 27, 2018
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. Import Failed labels Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants