Add Touchable E2E tests #22570
Add Touchable E2E tests #22570
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Generated by 🚫 dangerJS |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
LGTM! Here's a gif of the test:
@CodingItWrong do you think it's worth tapping again in each test to assert that the 2x presses register?
|
@rickhanlonii I like it; that provides more coverage and the tests should still be just about as fast and easy to read. Will do. |
facebook-github-bot
added
the
Import Started
There was a problem hiding this comment.
@TheSavior is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@CodingItWrong merged commit 1bc704d into |
Summary: Adds some initial tests for Touchable*. It only tests the first screen worth of examples; in a separate PR I'll work on an alternate way to "scroll" to individual examples in tests, before I add tests for the rest of the Touchable examples. On the live stream where I began writing these tests, I reorganized the "Touchable feedback examples" to the top of the list so it would be on-screen for testing. I didn't include this reorganization or test in this PR; that can be added in once the "alternative to scrolling" is added in, to avoid having to reorganize. Changelog: ---------- [General] [Added] - Add E2E tests for Touchable Pull Request resolved: #22570 Differential Revision: D13400348 Pulled By: TheSavior fbshipit-source-id: 821af135296049090427a16472cc14dabeb10ab4
hramos
removed
Import Started
Summary: Adds some initial tests for Touchable*. It only tests the first screen worth of examples; in a separate PR I'll work on an alternate way to "scroll" to individual examples in tests, before I add tests for the rest of the Touchable examples. On the live stream where I began writing these tests, I reorganized the "Touchable feedback examples" to the top of the list so it would be on-screen for testing. I didn't include this reorganization or test in this PR; that can be added in once the "alternative to scrolling" is added in, to avoid having to reorganize. Changelog: ---------- [General] [Added] - Add E2E tests for Touchable Pull Request resolved: facebook#22570 Differential Revision: D13400348 Pulled By: TheSavior fbshipit-source-id: 821af135296049090427a16472cc14dabeb10ab4
Summary: Adds some initial tests for Touchable*. It only tests the first screen worth of examples; in a separate PR I'll work on an alternate way to "scroll" to individual examples in tests, before I add tests for the rest of the Touchable examples. On the live stream where I began writing these tests, I reorganized the "Touchable feedback examples" to the top of the list so it would be on-screen for testing. I didn't include this reorganization or test in this PR; that can be added in once the "alternative to scrolling" is added in, to avoid having to reorganize. Changelog: ---------- [General] [Added] - Add E2E tests for Touchable Pull Request resolved: facebook/react-native#22570 Differential Revision: D13400348 Pulled By: TheSavior fbshipit-source-id: 821af135296049090427a16472cc14dabeb10ab4
Adds some initial tests for Touchable*. It only tests the first screen worth of examples; in a separate PR I'll work on an alternate way to "scroll" to individual examples in tests, before I add tests for the rest of the Touchable examples.
On the live stream where I began writing these tests, I reorganized the "Touchable feedback examples" to the top of the list so it would be on-screen for testing. I didn't include this reorganization or test in this PR; that can be added in once the "alternative to scrolling" is added in, to avoid having to reorganize.
Changelog:
[General] [Added] - Add E2E tests for Touchable