-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detox debug build #22572
Detox debug build #22572
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Generated by 🚫 dangerJS |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition @CodingItWrong, just a minor suggestion to review
Co-Authored-By: CodingItWrong <joshjustice@me.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@CodingItWrong merged commit fb16af7 into |
Summary: Adds a Detox configuration and instructions for running the app in development mode in Detox. This speeds up developing tests, because changes to production code don't require a full rebuild. Pull Request resolved: #22572 Differential Revision: D13396883 Pulled By: cpojer fbshipit-source-id: 186cc8d75eccae411b602cb0f68f0e11856e0743
Summary: Adds a Detox configuration and instructions for running the app in development mode in Detox. This speeds up developing tests, because changes to production code don't require a full rebuild. Pull Request resolved: facebook#22572 Differential Revision: D13396883 Pulled By: cpojer fbshipit-source-id: 186cc8d75eccae411b602cb0f68f0e11856e0743
Summary: Adds a Detox configuration and instructions for running the app in development mode in Detox. This speeds up developing tests, because changes to production code don't require a full rebuild. Pull Request resolved: facebook/react-native#22572 Differential Revision: D13396883 Pulled By: cpojer fbshipit-source-id: 186cc8d75eccae411b602cb0f68f0e11856e0743
Adds a Detox configuration and instructions for running the app in development mode in Detox. This speeds up developing tests, because changes to production code don't require a full rebuild.
Test Plan:
As described in
RNTester/Readme.md
:When developing E2E tests, you may want to run in development mode, so that changes to the production code show up immediately. To do this, run:
The previous release mode can still be done by running:
Or:
Changelog:
[General] [Added] - Add debug configuration for Detox tests