Don't reconnect inspector if connection refused #22625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Together with a pr to react-devtools) Fixes facebook#21030
facebook-github-bot
added
the
CLA Signed
Generated by 🚫 dangerJS |
msand
added a commit
to msand/react-devtools
that referenced
this pull request
Dec 12, 2018
(Together with a pr to react-native facebook/react-native#22625) Fixes facebook/react-native#21030
|
This seems OK - let's wait for facebook/react-devtools#1248 to be merged. |
|
@hramos Can we merge this first? I can not see why this pr should wait for the other? |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Feb 21, 2019
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hramos
removed
Import Started
sunnylqm
pushed a commit
to sunnylqm/react-native
that referenced
this pull request
Feb 24, 2019
Summary: (Together with a pr to react-devtools) Fixes facebook#21030 [iOS] [Fixed] - Fix infinite retry loop of inspector Pull Request resolved: facebook#22625 Differential Revision: D14169392 Pulled By: hramos fbshipit-source-id: 2e301fd9d458598b62399fc61a9859ad29928483
aleclarson
pushed a commit
to aleclarson/react-native-macos
that referenced
this pull request
Jun 14, 2019
Summary: (Together with a pr to react-devtools) Fixes facebook/react-native#21030 [iOS] [Fixed] - Fix infinite retry loop of inspector Pull Request resolved: facebook/react-native#22625 Differential Revision: D14169392 Pulled By: hramos fbshipit-source-id: 2e301fd9d458598b62399fc61a9859ad29928483
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: (Together with a pr to react-devtools) Fixes facebook#21030 [iOS] [Fixed] - Fix infinite retry loop of inspector Pull Request resolved: facebook#22625 Differential Revision: D14169392 Pulled By: hramos fbshipit-source-id: 2e301fd9d458598b62399fc61a9859ad29928483
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Together with a pr to react-devtools) Fixes #21030
Changelog
[iOS] [Fixed] - Fix infinite retry loop of inspector