Fix RNTesterUnitTests failure #22658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add JavaScriptCore.framework to RNTester's RNTesterUnitTests target. This resolves the failure seen when running `scripts/objc-test-ios.sh test` seen in Circle CI. See D9875409 for a related diff (facebook@78fcf7c in open source). Without this diff, `scripts/objc-test-ios.sh test` would fail with the following error (see Circle https://circleci.com/gh/facebook/react-native/63704): ``` � ld: symbol(s) not found for architecture x86_64 � clang: error: linker command failed with exit code 1 (use -v to see invocation) Testing failed: "_JSObjectGetPrototype", referenced from: "_JSObjectSetPrototype", referenced from: "_JSPropertyNameAccumulatorAddName", referenced from: "_JSObjectCopyPropertyNames", referenced from: "_JSContextGetGlobalObject", referenced from: "_JSValueMakeString", referenced from: "_JSValueIsNumber", referenced from: "_JSClassCreate", referenced from: "_JSObjectGetPropertyAtIndex", referenced from: "_JSObjectMakeArray", referenced from: "_JSEvaluateScript", referenced from: "_JSValueIsUndefined", referenced from: "_JSPropertyNameArrayGetCount", referenced from: "_JSPropertyNameArrayGetNameAtIndex", referenced from: "_JSPropertyNameArrayRelease", referenced from: "_JSValueMakeUndefined", referenced from: "_JSValueMakeNull", referenced from: "_JSStringCreateWithUTF8CString", referenced from: "_JSObjectSetProperty", referenced from: "_JSObjectHasProperty", referenced from: "_kJSClassDefinitionEmpty", referenced from: "_JSObjectIsFunction", referenced from: "_JSValueIsBoolean", referenced from: "_JSValueIsInstanceOfConstructor", referenced from: "_JSValueIsObjectOfClass", referenced from: "_JSValueToNumber", referenced from: "_JSGlobalContextRelease", referenced from: "_JSValueToBoolean", referenced from: "_JSValueIsArray", referenced from: "_JSValueMakeNumber", referenced from: "_JSObjectSetPrivate", referenced from: "_JSValueIsNull", referenced from: "_JSObjectSetPropertyAtIndex", referenced from: "_JSValueIsObject", referenced from: "_JSValueMakeBoolean", referenced from: "_JSValueUnprotect", referenced from: "_JSValueToStringCopy", referenced from: "_JSObjectGetProperty", referenced from: "_JSValueToObject", referenced from: "_JSObjectGetPrivate", referenced from: "_JSStringRelease", referenced from: "_JSGlobalContextRetain", referenced from: "_JSStringIsEqual", referenced from: "_JSStringGetMaximumUTF8CStringSize", referenced from: "_JSObjectCallAsFunction", referenced from: "_JSStringGetUTF8CString", referenced from: "_JSValueProtect", referenced from: "_JSValueIsString", referenced from: "_JSStringRetain", referenced from: "_JSObjectMake", referenced from: "_JSGlobalContextCreateInGroup", referenced from: "_JSObjectCallAsConstructor", referenced from: Linker command failed with exit code 1 (use -v to see invocation) Testing cancelled because the build failed. ** TEST FAILED ** ``` Differential Revision: D13474936 fbshipit-source-id: 5202a3a166978681810cecfff8611430af91a4f7
facebook-github-bot
added
CLA Signed
grabbou
pushed a commit
that referenced
this pull request
Dec 19, 2018
Summary: Pull Request resolved: #22658 Add JavaScriptCore.framework to RNTester's RNTesterUnitTests target. This resolves the failure seen when running `scripts/objc-test-ios.sh test` seen in Circle CI. See D9875409 for a related diff (78fcf7c in open source). Without this diff, `scripts/objc-test-ios.sh test` would fail with the following error (see Circle https://circleci.com/gh/facebook/react-native/63704): ``` � ld: symbol(s) not found for architecture x86_64 � clang: error: linker command failed with exit code 1 (use -v to see invocation) Testing failed: "_JSObjectGetPrototype", referenced from: "_JSObjectSetPrototype", referenced from: "_JSPropertyNameAccumulatorAddName", referenced from: "_JSObjectCopyPropertyNames", referenced from: "_JSContextGetGlobalObject", referenced from: "_JSValueMakeString", referenced from: "_JSValueIsNumber", referenced from: "_JSClassCreate", referenced from: "_JSObjectGetPropertyAtIndex", referenced from: "_JSObjectMakeArray", referenced from: "_JSEvaluateScript", referenced from: "_JSValueIsUndefined", referenced from: "_JSPropertyNameArrayGetCount", referenced from: "_JSPropertyNameArrayGetNameAtIndex", referenced from: "_JSPropertyNameArrayRelease", referenced from: "_JSValueMakeUndefined", referenced from: "_JSValueMakeNull", referenced from: "_JSStringCreateWithUTF8CString", referenced from: "_JSObjectSetProperty", referenced from: "_JSObjectHasProperty", referenced from: "_kJSClassDefinitionEmpty", referenced from: "_JSObjectIsFunction", referenced from: "_JSValueIsBoolean", referenced from: "_JSValueIsInstanceOfConstructor", referenced from: "_JSValueIsObjectOfClass", referenced from: "_JSValueToNumber", referenced from: "_JSGlobalContextRelease", referenced from: "_JSValueToBoolean", referenced from: "_JSValueIsArray", referenced from: "_JSValueMakeNumber", referenced from: "_JSObjectSetPrivate", referenced from: "_JSValueIsNull", referenced from: "_JSObjectSetPropertyAtIndex", referenced from: "_JSValueIsObject", referenced from: "_JSValueMakeBoolean", referenced from: "_JSValueUnprotect", referenced from: "_JSValueToStringCopy", referenced from: "_JSObjectGetProperty", referenced from: "_JSValueToObject", referenced from: "_JSObjectGetPrivate", referenced from: "_JSStringRelease", referenced from: "_JSGlobalContextRetain", referenced from: "_JSStringIsEqual", referenced from: "_JSStringGetMaximumUTF8CStringSize", referenced from: "_JSObjectCallAsFunction", referenced from: "_JSStringGetUTF8CString", referenced from: "_JSValueProtect", referenced from: "_JSValueIsString", referenced from: "_JSStringRetain", referenced from: "_JSObjectMake", referenced from: "_JSGlobalContextCreateInGroup", referenced from: "_JSObjectCallAsConstructor", referenced from: Linker command failed with exit code 1 (use -v to see invocation) Testing cancelled because the build failed. ** TEST FAILED ** ``` Reviewed By: fkgozali Differential Revision: D13474936 fbshipit-source-id: b12ddd6dcb95a7a588463d74cc0798dd591bdd78
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Pull Request resolved: facebook#22658 Add JavaScriptCore.framework to RNTester's RNTesterUnitTests target. This resolves the failure seen when running `scripts/objc-test-ios.sh test` seen in Circle CI. See D9875409 for a related diff (facebook@78fcf7c in open source). Without this diff, `scripts/objc-test-ios.sh test` would fail with the following error (see Circle https://circleci.com/gh/facebook/react-native/63704): ``` � ld: symbol(s) not found for architecture x86_64 � clang: error: linker command failed with exit code 1 (use -v to see invocation) Testing failed: "_JSObjectGetPrototype", referenced from: "_JSObjectSetPrototype", referenced from: "_JSPropertyNameAccumulatorAddName", referenced from: "_JSObjectCopyPropertyNames", referenced from: "_JSContextGetGlobalObject", referenced from: "_JSValueMakeString", referenced from: "_JSValueIsNumber", referenced from: "_JSClassCreate", referenced from: "_JSObjectGetPropertyAtIndex", referenced from: "_JSObjectMakeArray", referenced from: "_JSEvaluateScript", referenced from: "_JSValueIsUndefined", referenced from: "_JSPropertyNameArrayGetCount", referenced from: "_JSPropertyNameArrayGetNameAtIndex", referenced from: "_JSPropertyNameArrayRelease", referenced from: "_JSValueMakeUndefined", referenced from: "_JSValueMakeNull", referenced from: "_JSStringCreateWithUTF8CString", referenced from: "_JSObjectSetProperty", referenced from: "_JSObjectHasProperty", referenced from: "_kJSClassDefinitionEmpty", referenced from: "_JSObjectIsFunction", referenced from: "_JSValueIsBoolean", referenced from: "_JSValueIsInstanceOfConstructor", referenced from: "_JSValueIsObjectOfClass", referenced from: "_JSValueToNumber", referenced from: "_JSGlobalContextRelease", referenced from: "_JSValueToBoolean", referenced from: "_JSValueIsArray", referenced from: "_JSValueMakeNumber", referenced from: "_JSObjectSetPrivate", referenced from: "_JSValueIsNull", referenced from: "_JSObjectSetPropertyAtIndex", referenced from: "_JSValueIsObject", referenced from: "_JSValueMakeBoolean", referenced from: "_JSValueUnprotect", referenced from: "_JSValueToStringCopy", referenced from: "_JSObjectGetProperty", referenced from: "_JSValueToObject", referenced from: "_JSObjectGetPrivate", referenced from: "_JSStringRelease", referenced from: "_JSGlobalContextRetain", referenced from: "_JSStringIsEqual", referenced from: "_JSStringGetMaximumUTF8CStringSize", referenced from: "_JSObjectCallAsFunction", referenced from: "_JSStringGetUTF8CString", referenced from: "_JSValueProtect", referenced from: "_JSValueIsString", referenced from: "_JSStringRetain", referenced from: "_JSObjectMake", referenced from: "_JSGlobalContextCreateInGroup", referenced from: "_JSObjectCallAsConstructor", referenced from: Linker command failed with exit code 1 (use -v to see invocation) Testing cancelled because the build failed. ** TEST FAILED ** ``` Reviewed By: fkgozali Differential Revision: D13474936 fbshipit-source-id: b12ddd6dcb95a7a588463d74cc0798dd591bdd78
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Jul 18, 2019
Summary: Pull Request resolved: facebook/react-native#22658 Add JavaScriptCore.framework to RNTester's RNTesterUnitTests target. This resolves the failure seen when running `scripts/objc-test-ios.sh test` seen in Circle CI. See D9875409 for a related diff (facebook/react-native@78fcf7c in open source). Without this diff, `scripts/objc-test-ios.sh test` would fail with the following error (see Circle https://circleci.com/gh/facebook/react-native/63704): ``` � ld: symbol(s) not found for architecture x86_64 � clang: error: linker command failed with exit code 1 (use -v to see invocation) Testing failed: "_JSObjectGetPrototype", referenced from: "_JSObjectSetPrototype", referenced from: "_JSPropertyNameAccumulatorAddName", referenced from: "_JSObjectCopyPropertyNames", referenced from: "_JSContextGetGlobalObject", referenced from: "_JSValueMakeString", referenced from: "_JSValueIsNumber", referenced from: "_JSClassCreate", referenced from: "_JSObjectGetPropertyAtIndex", referenced from: "_JSObjectMakeArray", referenced from: "_JSEvaluateScript", referenced from: "_JSValueIsUndefined", referenced from: "_JSPropertyNameArrayGetCount", referenced from: "_JSPropertyNameArrayGetNameAtIndex", referenced from: "_JSPropertyNameArrayRelease", referenced from: "_JSValueMakeUndefined", referenced from: "_JSValueMakeNull", referenced from: "_JSStringCreateWithUTF8CString", referenced from: "_JSObjectSetProperty", referenced from: "_JSObjectHasProperty", referenced from: "_kJSClassDefinitionEmpty", referenced from: "_JSObjectIsFunction", referenced from: "_JSValueIsBoolean", referenced from: "_JSValueIsInstanceOfConstructor", referenced from: "_JSValueIsObjectOfClass", referenced from: "_JSValueToNumber", referenced from: "_JSGlobalContextRelease", referenced from: "_JSValueToBoolean", referenced from: "_JSValueIsArray", referenced from: "_JSValueMakeNumber", referenced from: "_JSObjectSetPrivate", referenced from: "_JSValueIsNull", referenced from: "_JSObjectSetPropertyAtIndex", referenced from: "_JSValueIsObject", referenced from: "_JSValueMakeBoolean", referenced from: "_JSValueUnprotect", referenced from: "_JSValueToStringCopy", referenced from: "_JSObjectGetProperty", referenced from: "_JSValueToObject", referenced from: "_JSObjectGetPrivate", referenced from: "_JSStringRelease", referenced from: "_JSGlobalContextRetain", referenced from: "_JSStringIsEqual", referenced from: "_JSStringGetMaximumUTF8CStringSize", referenced from: "_JSObjectCallAsFunction", referenced from: "_JSStringGetUTF8CString", referenced from: "_JSValueProtect", referenced from: "_JSValueIsString", referenced from: "_JSStringRetain", referenced from: "_JSObjectMake", referenced from: "_JSGlobalContextCreateInGroup", referenced from: "_JSObjectCallAsConstructor", referenced from: Linker command failed with exit code 1 (use -v to see invocation) Testing cancelled because the build failed. ** TEST FAILED ** ``` Reviewed By: fkgozali Differential Revision: D13474936 fbshipit-source-id: b12ddd6dcb95a7a588463d74cc0798dd591bdd78
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add JavaScriptCore.framework to RNTester's RNTesterUnitTests target. This resolves the failure seen when running
scripts/objc-test-ios.sh testseen in Circle CI.See D9875409 for a related diff (78fcf7c in open source).
Without this diff,
scripts/objc-test-ios.sh testwould fail with the following error (see Circle https://circleci.com/gh/facebook/react-native/63704):Differential Revision: D13474936