[CI] test_ios → ✅: Update iOS Snapshots, remove tvOS tests, disable failing tests #22720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
hramos
force-pushed
the
disable-tests-objc
branch
2 times, most recently
from
69b3e99 to
1463a77
Compare
hramos
changed the title
hramos
added
the
🔩Test Infrastructure
|
@hramos, Thanks for let me know, I will try to identify and solve. |
hramos
force-pushed
the
disable-tests-objc
branch
from
a3b64e6 to
a004e48
Compare
hramos
changed the title
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Dec 20, 2018
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
grabbou
pushed a commit
that referenced
this pull request
Dec 24, 2018
…g tests (#22720) Summary: The following tests are disabled in this PR: - testTimersTest is failing due to undefined this.setTimeout, probably introduced back in 61346d3. Tracking a fix in #22695 - testTheTester_ExpectError is failing as RCTTestRunner is not properly passing through the error. Tracking a fix in #22697 I've added a comment regarding testWebSocketTest and how to ensure it passes locally. This PR also fixes all remaining snapshot tests, which were failing due to the use of iPhone XS as a iOS Simulator on Circle CI. We are using iPhone 6s for SST internally, and this allows us to be consistent. Pull Request resolved: #22720 Differential Revision: D13532788 Pulled By: hramos fbshipit-source-id: 75681236032839bf88180611ee68826b53cc96eb
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
…g tests (facebook#22720) Summary: The following tests are disabled in this PR: - testTimersTest is failing due to undefined this.setTimeout, probably introduced back in 61346d3. Tracking a fix in facebook#22695 - testTheTester_ExpectError is failing as RCTTestRunner is not properly passing through the error. Tracking a fix in facebook#22697 I've added a comment regarding testWebSocketTest and how to ensure it passes locally. This PR also fixes all remaining snapshot tests, which were failing due to the use of iPhone XS as a iOS Simulator on Circle CI. We are using iPhone 6s for SST internally, and this allows us to be consistent. Pull Request resolved: facebook#22720 Differential Revision: D13532788 Pulled By: hramos fbshipit-source-id: 75681236032839bf88180611ee68826b53cc96eb
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Jul 18, 2019
…g tests (#22720) Summary: The following tests are disabled in this PR: - testTimersTest is failing due to undefined this.setTimeout, probably introduced back in 61346d3. Tracking a fix in facebook/react-native#22695 - testTheTester_ExpectError is failing as RCTTestRunner is not properly passing through the error. Tracking a fix in facebook/react-native#22697 I've added a comment regarding testWebSocketTest and how to ensure it passes locally. This PR also fixes all remaining snapshot tests, which were failing due to the use of iPhone XS as a iOS Simulator on Circle CI. We are using iPhone 6s for SST internally, and this allows us to be consistent. Pull Request resolved: facebook/react-native#22720 Differential Revision: D13532788 Pulled By: hramos fbshipit-source-id: 75681236032839bf88180611ee68826b53cc96eb
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following tests are disabled in this PR:
I've added a comment regarding testWebSocketTest and how to ensure it passes locally.
This PR also fixes all remaining snapshot tests, which were failing due to the use of iPhone XS as a iOS Simulator on Circle CI. We are using iPhone 6s for SST internally, and this allows us to be consistent.
Test Plan:
Circle CI