Android: Add error description to Image onError callback #22737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
analysis-bot
suggested changes
Dec 20, 2018
|
404 support in fresco mentioned here seems to have landed (see "image-3" in ImageErrorTestCase) |
Jyrno42
force-pushed
the
bug-android-image-onError
branch
from
fd96b4f to
75033d4
Compare
react-native-bot
added
🔶Components
Component: Image
Platform: Android
Jyrno42
force-pushed
the
bug-android-image-onError
branch
from
75033d4 to
83d2625
Compare
|
@analysis-bot changes done |
**Test Plan**: Verified on CircleCI via integration tests. **Changelog:** [ANDROID][BUGFIX][Image] - Add error description to onError callback fixes facebook#19073
Jyrno42
force-pushed
the
bug-android-image-onError
branch
from
83d2625 to
9d6e5ec
Compare
|
cc @hramos |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jan 15, 2019
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
matthargett
approved these changes
Jan 23, 2019
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
) Summary: fixes facebook#19073 Changelog: ---------- [Android] [Fixed] - Add error description to Image onError callback Pull Request resolved: facebook#22737 Differential Revision: D13676224 Pulled By: hramos fbshipit-source-id: 0dea7e97ae6517b8980ad02827f19d22cd3ef933
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
) Summary: fixes facebook#19073 Changelog: ---------- [Android] [Fixed] - Add error description to Image onError callback Pull Request resolved: facebook#22737 Differential Revision: D13676224 Pulled By: hramos fbshipit-source-id: 0dea7e97ae6517b8980ad02827f19d22cd3ef933
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19073
Changelog:
[Android] [Fixed] - Add error description to Image onError callback
Test Plan:
Verified on CircleCI via integration tests.