Remove unused files and code for old JSC and gcc build #23014
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Unused prebuilt old JSC for 64bits. 2. Folly patch for gcc build.
facebook-github-bot
added
the
CLA Signed
|
Restart it, looks like now build. |
gengjiawen
approved these changes
Jan 16, 2019
|
Hey @Kudo , thank you for the contribution! Since this change isn't user impacting, I likely will suggest that we not add an entry in the changelog. Nevertheless, the cleanup is appreciated. Cheers! |
|
@gengjiawen Thank you for the CI re-trigger. @turnrye Revised, please take a look. Thanks for your awesome work to summerize the changelog. |
dulmandakh
approved these changes
Jan 16, 2019
|
@facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jan 16, 2019
There was a problem hiding this comment.
@dulmandakh is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@cpojer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
grabbou
pushed a commit
that referenced
this pull request
Jan 16, 2019
Summary: ---------- 1. Unused prebuilt old JSC for 64bits. 2. Folly patch for gcc build. Pull Request resolved: #23014 Differential Revision: D13690139 Pulled By: cpojer fbshipit-source-id: 64555f5b9a5fbd4156e42eeff13da721846c2521
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: ---------- 1. Unused prebuilt old JSC for 64bits. 2. Folly patch for gcc build. Pull Request resolved: facebook#23014 Differential Revision: D13690139 Pulled By: cpojer fbshipit-source-id: 64555f5b9a5fbd4156e42eeff13da721846c2521
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: ---------- 1. Unused prebuilt old JSC for 64bits. 2. Folly patch for gcc build. Pull Request resolved: facebook#23014 Differential Revision: D13690139 Pulled By: cpojer fbshipit-source-id: 64555f5b9a5fbd4156e42eeff13da721846c2521
facebook-github-bot
added
Contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan: