android support library 28.0.0 #23109
Conversation
facebook-github-bot
added
the
CLA Signed
|
@mdvacca Android CI is green |
There was a problem hiding this comment.
@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
| @@ -1,54 +1,131 @@ | |||
| load("//tools/build_defs:fb_native_wrapper.bzl", "fb_native") | |||
| load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep") | |||
There was a problem hiding this comment.
Can you add "rn_prebuilt_jar" here?
load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "rn_prebuilt_jar")
| ":swiperefreshlayout", | ||
| ":versionedparcelable", | ||
| ":viewpager", | ||
| react_native_dep("third-party/android/support-annotations:android-support-annotations"), |
There was a problem hiding this comment.
let's replace this for:
":android-support-annotations",
| ":swiperefreshlayout", | ||
| ":versionedparcelable", | ||
| ":viewpager", | ||
| react_native_dep("third-party/android/support-annotations:android-support-annotations"), | ||
| ], | ||
| ) | ||
|
|
There was a problem hiding this comment.
can you add?
fb_native.prebuilt_jar(
name = "android-support-annotations",
binary_jar = ":support-annotations-binary.jar",
)
| url = "mvn:android.arch.lifecycle:runtime:aar:1.1.0", | ||
| name = "asynclayoutinflater-aar", | ||
| sha1 = "3ae7643d120e6da3adbe2d698de923f48c904d1f", | ||
| url = "mvn:com.android.support:asynclayoutinflater:aar:28.0.0", | ||
| ) | ||
|
|
There was a problem hiding this comment.
can you add?
fb_native.remote_file(
name = "support-annotations-binary.jar",
sha1 = "ed73f5337a002d1fd24339d5fb08c2c9d9ca60d8",
url = "mvn:com.android.support:support-annotations:jar:28.0.0",
)
There was a problem hiding this comment.
@mdvacca has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
added
the
Import Started
|
@dulmandakh merged commit 5bbed43 into |
Summary: Bump Android Support Library to 28.0.0. Therefore fix Android CI Changelog: ---------- [Android] [Changed] - Bump Android Support Library to 28.0.0. Pull Request resolved: #23109 Differential Revision: D13779835 Pulled By: mdvacca fbshipit-source-id: 7645ffe2c04ca81424b2f9cfa43dc4ec30c50e25
hramos
removed
Import Started
Summary: Bump Android Support Library to 28.0.0. Therefore fix Android CI Changelog: ---------- [Android] [Changed] - Bump Android Support Library to 28.0.0. Pull Request resolved: facebook#23109 Differential Revision: D13779835 Pulled By: mdvacca fbshipit-source-id: 7645ffe2c04ca81424b2f9cfa43dc4ec30c50e25
Summary: Bump Android Support Library to 28.0.0. Therefore fix Android CI Changelog: ---------- [Android] [Changed] - Bump Android Support Library to 28.0.0. Pull Request resolved: facebook#23109 Differential Revision: D13779835 Pulled By: mdvacca fbshipit-source-id: 7645ffe2c04ca81424b2f9cfa43dc4ec30c50e25
Bump Android Support Library to 28.0.0. Therefore fix Android CI
Changelog:
[Android] [Changed] - Bump Android Support Library to 28.0.0.
Test Plan:
CI is green