Remove TabBarExample from Screenshot Tests #23206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hramos
added
the
🔩Test Infrastructure
facebook-github-bot
added
the
CLA Signed
|
Confirmed, |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Jan 29, 2019
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hramos
removed
Import Started
matt-oakes
pushed a commit
to matt-oakes/react-native
that referenced
this pull request
Feb 7, 2019
Summary: Fixes facebook#23108. The TabBarIOS component is scheduled to be removed from core any day now, so it's OK to remove it from our test suite. Changelog: ---------- [iOS] [Removed] - Remove TabBarExample SST Pull Request resolved: facebook#23206 Differential Revision: D13864064 Pulled By: hramos fbshipit-source-id: f65da75e2789d384dcd713a27ca5528f0faa7526
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Jul 18, 2019
Summary: Fixes facebook/react-native#23108. The TabBarIOS component is scheduled to be removed from core any day now, so it's OK to remove it from our test suite. Changelog: ---------- [iOS] [Removed] - Remove TabBarExample SST Pull Request resolved: facebook/react-native#23206 Differential Revision: D13864064 Pulled By: hramos fbshipit-source-id: f65da75e2789d384dcd713a27ca5528f0faa7526
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23108. The TabBarIOS component is scheduled to be removed from core any day now, so it's OK to remove it from our test suite.
Changelog:
[iOS] [Removed] - Remove TabBarExample SST
Test Plan:
Confirm test_ios succeeds on CI.