Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken jsiexecutor search path. #23274

Closed
wants to merge 1 commit into from
Closed

Fix broken jsiexecutor search path. #23274

wants to merge 1 commit into from

Conversation

amccarri
Copy link
Contributor

@amccarri amccarri commented Feb 3, 2019

Summary

This resolves issue #23217.

Change-log

iOS apps no longer run into missing header files for JSIExecutor.

Test Plan

  1. Create native iOS app.
  2. Add react native using master branch as documented in the guides.
  3. Run pod install on iOS portion of project.
  4. Compile the native app in Xcode.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@pull-bot
Copy link

pull-bot commented Feb 3, 2019

Warnings
⚠️

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

Generated by 🚫 dangerJS

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 3, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

cpojer
cpojer approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Feb 4, 2019
facebook-github-bot
facebook-github-bot approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

@amccarri merged commit 2aa2401 into facebook:master.

@facebook facebook locked as resolved and limited conversation to collaborators Feb 4, 2019
@react-native-bot react-native-bot added the Merged This PR has been merged. label Feb 4, 2019
@hramos hramos removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Feb 6, 2019
matt-oakes pushed a commit to matt-oakes/react-native that referenced this pull request Feb 7, 2019
@amccarri @facebook-github-bot
Fix broken jsiexecutor search path. (facebook#23274)
38035c8 
Summary:
This resolves issue facebook#23217.

iOS apps no longer run into missing header files for JSIExecutor.
Pull Request resolved: facebook#23274

Differential Revision: D13941752

Pulled By: cpojer

fbshipit-source-id: 9415db4d160901386e2e926b56831be0d3ee9d2b
grabbou pushed a commit that referenced this pull request Feb 18, 2019
@amccarri @grabbou
Fix broken jsiexecutor search path. (#23274)
519ad8c 
Summary:
This resolves issue #23217.

iOS apps no longer run into missing header files for JSIExecutor.
Pull Request resolved: #23274

Differential Revision: D13941752

Pulled By: cpojer

fbshipit-source-id: 9415db4d160901386e2e926b56831be0d3ee9d2b
t-nanava pushed a commit to microsoft/react-native-macos that referenced this pull request Jun 17, 2019
@amccarri @grabbou
Fix broken jsiexecutor search path. (facebook#23274)
cd166a8 
Summary:
This resolves issue facebook#23217.

iOS apps no longer run into missing header files for JSIExecutor.
Pull Request resolved: facebook#23274

Differential Revision: D13941752

Pulled By: cpojer

fbshipit-source-id: 9415db4d160901386e2e926b56831be0d3ee9d2b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

@cpojer cpojer cpojer approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amccarri @facebook-github-bot @pull-bot @react-native-bot @cpojer @hramos