Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Add CocoaPods Podfile to the project template #23563

Closed
wants to merge 15 commits into from
Closed

[iOS] Add CocoaPods Podfile to the project template #23563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
4f290f9
Add CocoaPods to the project template
fson Jan 17, 2019
f3ea2b7
Set iOS target to 9.0 to match the current Xcode project setting
fson Feb 21, 2019
612a2ea
Remove references to individual libraries from xcodeproj
fson Feb 21, 2019
cae1b18
Add missing Tests, tvOS and tvOSTests targets
fson Feb 21, 2019
4e55a10
Update Podfile to match the new podspecs
fson Feb 22, 2019
1f719ae
Add Start Packager scripts to HelloWorld.xcodeproj
fson Mar 19, 2019
a9d10b0
Run pod install in the iOS e2e test
fson Mar 19, 2019
2437729
Build the workspace instead of project in iOS e2e tests
fson Mar 19, 2019
7a0bc6d
Fix linting error
fson Mar 21, 2019
03b069c
Add a newline at EOF
fson Mar 21, 2019
0033a72
Remove lines autogenerated by pod install from xcodeproj
fson Mar 21, 2019
8c90c50
Remove "Pods" group, it's autogenerated in pod install
fson Mar 21, 2019
f1d8b15
Remove the `use_frameworks!` comment from the tvOS target
fson Mar 21, 2019
808204d
Remove libReact.a from frameworks
fson Mar 21, 2019
a5d109f
Update .gitignore
cpojer Mar 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,3 +69,7 @@ package-lock.json
# ReactCommon subdir shouldn't have Xcode project
/ReactCommon/**/*.xcodeproj
RNTester/build

# CocoaPods
/template/ios/Pods/
/template/ios/Podfile.lock
4 changes: 4 additions & 0 deletions scripts/run-ci-e2e-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,8 @@ try {
'response=$(curl --write-out %{http_code} --silent --output /dev/null localhost:8081/index.bundle?platform=ios&dev=true)',
);
echo(`Starting packager server, ${SERVER_PID}`);
echo('Running pod install');
exec('pod install');
echo('Executing ' + iosTestType + ' end-to-end test');
if (
tryExecNTimes(() => {
Expand All @@ -204,6 +206,8 @@ try {
return exec(
[
'xcodebuild',
'-workspace',
cpojer marked this conversation as resolved.
Show resolved Hide resolved
'"EndToEndTest.xcworkspace"',
'-destination',
`"${destination}"`,
'-scheme',
Expand Down
3 changes: 3 additions & 0 deletions template/_gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,6 @@ buck-out/

# Bundle artifact
*.jsbundle

# CocoaPods
/ios/Pods/
Loading