chore: update Jest preset to align with Jest 24 #24062
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
approved these changes
Mar 20, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @thymikee in 23ef604. When will my fix make it into a release? | Upcoming Releases |
grabbou
pushed a commit
that referenced
this pull request
Apr 8, 2019
Summary: Jest 24 includes [`testMatch` and `moduleFileExtensions`](https://github.com/facebook/jest/blob/c5fd7aae93764c13c259ae9a73846c10e84ae2a3/packages/jest-config/src/Defaults.ts#L70) that align with the ones that are currently there on master, because it added default handling for TypeScript as well. I think it's time for us to move to Jest 24. Is there a way we can tell users to upgrade Jest to certain version? Fixes #24060 [General] [Changed] - update Jest preset to align with Jest 24 Pull Request resolved: #24062 Differential Revision: D14538988 Pulled By: cpojer fbshipit-source-id: d8d152b8e8517b34144970f1cc1ed0b49f8b4e54
aleclarson
pushed a commit
to alloc/react-native-macos
that referenced
this pull request
Nov 15, 2019
Summary: Jest 24 includes [`testMatch` and `moduleFileExtensions`](https://github.com/facebook/jest/blob/c5fd7aae93764c13c259ae9a73846c10e84ae2a3/packages/jest-config/src/Defaults.ts#L70) that align with the ones that are currently there on master, because it added default handling for TypeScript as well. I think it's time for us to move to Jest 24. Is there a way we can tell users to upgrade Jest to certain version? Fixes facebook/react-native#24060 [General] [Changed] - update Jest preset to align with Jest 24 Pull Request resolved: facebook/react-native#24062 Differential Revision: D14538988 Pulled By: cpojer fbshipit-source-id: d8d152b8e8517b34144970f1cc1ed0b49f8b4e54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Jest 24 includes
testMatchandmoduleFileExtensionsthat align with the ones that are currently there on master, because it added default handling for TypeScript as well. I think it's time for us to move to Jest 24. Is there a way we can tell users to upgrade Jest to certain version?Fixes #24060
Changelog
[General] [Changed] - update Jest preset to align with Jest 24
Test Plan
Tested on a fresh project with renaming
.js->.ts->.tsx