[Android] Make Linking.getInitialURL works properly even if current activity is not initialized #24748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
analysis-bot
suggested changes
May 8, 2019
…ctivity is not initialized
mu29
force-pushed
the
fix/android-deep-link
branch
from
e8e6520
to
a92f8b2
Compare
facebook-github-bot
approved these changes
May 8, 2019
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @mu29 in c802d0b. When will my fix make it into a release? | Upcoming Releases |
|
This change seems to be causing this issue #25675 |
|
UPDATE: I don't believe this change is responsible (or at least not wholly responsible). See update on #25675 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solves #15961 - [ANDROID] Linking.getInitialURL() returns null after exiting the app with back button and using deep linking again (only in production!)
As the issue says, it seems that
currentActivityis null in IntentModule#getInitialURL. So I used theInteractionManagerto wait until current activity to finish initializing.Changelog
[Android] [Fixed] - In
Linking.getInitialURLmethod, use theInteractionManagerto wait for the current activity to finish initializing.Test Plan
Here is an error case. After several trial, my app cannot open deep link.
Video link: https://youtu.be/0qppEs4O1Ls