-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Fixes renderingMode not applied to GIF images #24794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @zhongwuzw in 75380aa. When will my fix make it into a release? | Upcoming Releases |
<Image The above code works on react native 0.60.x but not working on the latest version. |
@zhongwuzw Please check this issue again. |
this issue still exists on ios react: 17.0.2, react-native: 0.68.2 |
Summary
Bugs like #24789, we don't apply tintColor to GIF. We fixes it by setting a poster image before add animation.
cc. @cpojer .
Changelog
[iOS] [Fixed] - Fixes renderingMode not applied to GIF images
Test Plan
Original gif:
apply tintColor: