Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fixes renderingMode not applied to GIF images #24794

Closed
wants to merge 1 commit into from

Conversation

zhongwuzw
Copy link
Contributor

Summary

Bugs like #24789, we don't apply tintColor to GIF. We fixes it by setting a poster image before add animation.

cc. @cpojer .

Changelog

[iOS] [Fixed] - Fixes renderingMode not applied to GIF images

Test Plan

        <Image
              source={require('./test_tintColor.gif')}
              style={[styles.icon, {tintColor: 'blue'}]}
            />

Original gif:
test_tintColor

apply tintColor:
2019-05-10 16_35_45

@zhongwuzw zhongwuzw requested a review from shergin as a code owner May 10, 2019 08:37
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 10, 2019
Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @zhongwuzw in 75380aa.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label May 13, 2019
@joepake
Copy link

joepake commented Jan 11, 2020

<Image
source={require('./test_tintColor.gif')}
style={[styles.icon, {tintColor: 'blue'}]}
/>

The above code works on react native 0.60.x but not working on the latest version.
"react": "16.12.0",
"react-native": "^0.61.5"

@joepake
Copy link

joepake commented Jun 21, 2020

@zhongwuzw Please check this issue again.
The above code works on react native 0.60.x but not working on the v61, v62. Thanks.

@deflexable
Copy link

this issue still exists on ios react: 17.0.2, react-native: 0.68.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Component: Image Merged This PR has been merged. Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants