[TM] Add spec for Linking #24877
Closed
[TM] Add spec for Linking #24877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This comment has been minimized.
This comment has been minimized.
react-native-bot
added
API: Linking
Type: Enhancement
fkgozali
reviewed
May 16, 2019
Libraries/Linking/NativeLinking.js
Outdated
|
|
||
| const moduleName = | ||
| Platform.OS === 'ios' ? 'NativeLinkingManager' : 'NativeIntentAndroid'; | ||
| export default TurboModuleRegistry.getEnforcing<Spec>(moduleName); |
There was a problem hiding this comment.
Let's not use a variable for module name, so that scripting can collect these callsites (we have an internal script that find all JS callsites for a TurboModule).
if (Platform.OS === 'ios') {
export default TurboModuleRegistry.getEnforcing<Spec>('NativeLinkingManager');
} else {
export default TurboModuleRegistry.getEnforcing<Spec>('NativeIntentAndroid');
}
@RSNara: we probably should rename these modules in the native side to have the same name...
There was a problem hiding this comment.
@fkgozali btw, it is not legal to export that way.
There was a problem hiding this comment.
export default (Platform.OS === 'ios'
? TurboModuleRegistry.getEnforcing<Spec>('LinkingManager')
: TurboModuleRegistry.getEnforcing<Spec>('IntentAndroid'));^ is valid
|
lgtm, landing |
facebook-github-bot
approved these changes
May 16, 2019
There was a problem hiding this comment.
@fkgozali is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @ericlewis in 99899d0. When will my fix make it into a release? | Upcoming Releases |
M-i-k-e-l
pushed a commit
to M-i-k-e-l/react-native
that referenced
this pull request
Mar 10, 2020
Summary: Part of facebook#24875, adds a spec for linking. ## Changelog [General] [Added] - TM Spec for Linking Pull Request resolved: facebook#24877 Differential Revision: D15374328 Pulled By: fkgozali fbshipit-source-id: 4b86a75d58d275c0ddc864b4f3f1ec489b0b408b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #24875, adds a spec for linking.
Changelog
[General] [Added] - TM Spec for Linking
Test Plan
Flow passes.