-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TM] Add spec for SourceCode #24901
[TM] Add spec for SourceCode #24901
Conversation
I'm not too sure how to update tests that are directly writing to For instance:
or Lines 261 to 263 in 0815f81
Let me know your thoughts on this. |
Change them to getConstants() calls:
and
|
Thanks @ericlewis you put me on the right track 👍 This is what I did to fix the tests: 7eeb16b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @jeanregisser in 163fb08. When will my fix make it into a release? | Upcoming Releases |
Summary: Part of facebook#24875 ## Changelog [General] [Added] - Add TurboModule spec for SourceCode Pull Request resolved: facebook#24901 Reviewed By: fkgozali Differential Revision: D15391727 Pulled By: rickhanlonii fbshipit-source-id: 9d4622d809efdc3955d435c5a51b72c38cedccc5
Summary
Part of #24875
Changelog
[General] [Added] - Add TurboModule spec for SourceCode
Test Plan
Run
yarn flow-check-ios
andyarn flow-check-android
at the root level