[iOS] Add ultrabold pairs for font weight

[zhongwuzw]

Summary

Add ultrabold map of font weight, if not, ultrabold would map to bold.
Fixes #23512.

Changelog

[iOS] [Fixed] - Add ultrabold pairs for font weight

Test Plan

After:

<Text style={{fontFamily: 'GillSans-UltraBold'}}>Hello</Text>

<Text style={{fontFamily: 'GillSans-Bold'}}>Hello</Text>

Before:

<Text style={{fontFamily: 'GillSans-UltraBold'}}>Hello</Text>

<Text style={{fontFamily: 'GillSans-Bold'}}>Hello</Text>

[shergin]

Just curious, does it work in Fabric (without the fix)?
In Fabric we use:

static UIFontWeight RCTGetFontWeight(UIFont *font) {
  NSDictionary *traits =
      [font.fontDescriptor objectForKey:UIFontDescriptorTraitsAttribute];
  return [traits[UIFontWeightTrait] doubleValue];
}

Does it sufficient? Why should we parse the font name in the first place?

[zhongwuzw]

Just curious, does it work in Fabric (without the fix)?

🤔 After we fixes #24966, it works in this case.

In Fabric we use:

static UIFontWeight RCTGetFontWeight(UIFont *font) {
  NSDictionary *traits =
      [font.fontDescriptor objectForKey:UIFontDescriptorTraitsAttribute];
  return [traits[UIFontWeightTrait] doubleValue];
}

Does it sufficient? Why should we parse the font name in the first place?

From the discussion in #15162, seems it's not sufficient, because there has inconsistency for some fonts to parse weight, so we parse the font name in the first place. Should we also add that in Fabric? 🤔

[shergin]

inconsistency for some fonts to parse weight

Do you mean inconsistency between how iOS interprets the fonts and how classic RN does it? Or which kind of inconsistency?

[zhongwuzw]

@shergin Yeah, based on #15162, they said Roboto weight 200/300 both resolve to thin, but they should resolve to thin and light respectively.

[cpojer]

Let's ship it.

[facebook-github-bot]

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @zhongwuzw in 9d0d7b6.

^{When will my fix make it into a release? | Upcoming Releases}