Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary flag when running JS server #25517

Closed
wants to merge 2 commits into from

Conversation

thecodrr
Copy link
Contributor

@thecodrr thecodrr commented Jul 5, 2019

Summary

This removes the --projectRoot flag in launchPackager.bat as it was removed, fixing this bundler not opening issue on cli repo when yarn react-native run-android is run.

This is Windows related only so should be only tested on Windows.

Changelog

[Internal] [Fixed] - Fixed Metro Bundler not opening when running yarn react-native run-android

Test Plan

  1. Create a new repo using react-native init
  2. Edit the launchPackager.bat file
  3. Run yarn react-native run-android

This removes the --projectRoot flag in launchPackager.bat as it was removed and unnecessary fixing bundler not opening when `yarn react-native run-android` is run.
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@thymikee
Copy link
Contributor

thymikee commented Jul 5, 2019

@theweavrs please check this: react-native-community/cli#484 (comment) looks like we need another solution

@victorwpbastos
Copy link

victorwpbastos commented Jul 5, 2019

You should see react-native-community/cli#484 (comment) for clarification.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 5, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @theweavrs in a162554.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jul 9, 2019
grabbou pushed a commit that referenced this pull request Aug 7, 2019
Summary:
This removes the `--projectRoot` flag in `launchPackager.bat` as it was removed,  fixing [this bundler not opening issue on cli repo](react-native-community/cli#484) when `yarn react-native run-android` is run.

This is Windows related only so should be only tested on Windows.

## Changelog

[Internal] [Fixed] - Fixed Metro Bundler not opening when running `yarn react-native run-android`
Pull Request resolved: #25517

Test Plan:
1. Create a new repo using `react-native init`
2. Edit the `launchPackager.bat` file
3. Run `yarn react-native run-android`

Differential Revision: D16162108

Pulled By: cpojer

fbshipit-source-id: c12d9853ad49f00d56b9a8254a5b2c40a358cb2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants