-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary flag when running JS server #25517
Conversation
This removes the --projectRoot flag in launchPackager.bat as it was removed and unnecessary fixing bundler not opening when `yarn react-native run-android` is run.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
@theweavrs please check this: react-native-community/cli#484 (comment) looks like we need another solution |
You should see react-native-community/cli#484 (comment) for clarification. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was successfully merged by @theweavrs in a162554. When will my fix make it into a release? | Upcoming Releases |
Summary: This removes the `--projectRoot` flag in `launchPackager.bat` as it was removed, fixing [this bundler not opening issue on cli repo](react-native-community/cli#484) when `yarn react-native run-android` is run. This is Windows related only so should be only tested on Windows. ## Changelog [Internal] [Fixed] - Fixed Metro Bundler not opening when running `yarn react-native run-android` Pull Request resolved: #25517 Test Plan: 1. Create a new repo using `react-native init` 2. Edit the `launchPackager.bat` file 3. Run `yarn react-native run-android` Differential Revision: D16162108 Pulled By: cpojer fbshipit-source-id: c12d9853ad49f00d56b9a8254a5b2c40a358cb2e
Summary
This removes the
--projectRoot
flag inlaunchPackager.bat
as it was removed, fixing this bundler not opening issue on cli repo whenyarn react-native run-android
is run.This is Windows related only so should be only tested on Windows.
Changelog
[Internal] [Fixed] - Fixed Metro Bundler not opening when running
yarn react-native run-android
Test Plan
react-native init
launchPackager.bat
fileyarn react-native run-android