Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DEFINES_MODULE=YES to the yoga podspec #26276

Closed
wants to merge 1 commit into from

Conversation

janicduplessis
Copy link
Contributor

Summary

This fixes an error when using RN's version of yoga with Flipper.

[!] The following Swift pods cannot yet be integrated as static libraries:

The Swift pod `YogaKit` depends upon `Yoga`, which does not define modules. To opt into those targets generating module maps (which is necessary to import them from Swift when building as static libraries), you may set `use_modular_headers!` globally in your Podfile, or specify `:modular_headers => true` for particular dependencies.

Taken from https://github.com/facebook/yoga/blob/master/Yoga.podspec#L25

Changelog

[Internal] [Fixed] - Add DEFINES_MODULE=YES to the yoga podspec

Test Plan

Tested that pod install now works in an app.

This fixes an error when using RN's version of yoga with Flipper.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 30, 2019
@facebook-github-bot facebook-github-bot added the Contributor A React Native contributor. label Aug 30, 2019
@janicduplessis
Copy link
Contributor Author

cc @axemclion

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@axe-fb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@axe-fb
Copy link
Contributor

axe-fb commented Sep 1, 2019

Imported, waiting for review. Thanks @janicduplessis

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @janicduplessis in 0165489.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Sep 2, 2019
@hramos hramos deleted the janicduplessis-patch-10 branch February 25, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. Merged This PR has been merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants