Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for animating all properties using native driver #27506

Closed
wants to merge 24 commits into from
Closed

Add support for animating all properties using native driver #27506

wants to merge 24 commits into from

Commits on Dec 21, 2019

  1. [ios] Added support for animating unsupported props with useNativeDriver 

    - Added fix to interpolation node to make it work with colors
- Added support for differentiating between shadow view nodes and nodes that needs to be updated through the uimanager
- Added interfaces and configuration methods for setting up properties
    @chrfalch
    chrfalch committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    8c2e8cd View commit details
    Browse the repository at this point in the history

  2. [js] Added support for animating all props using native driver 

    - Added support for sharing the colorToRgba function
- Added configuration of allowed shadow view properties on startup
- Removed test to avoid using illegal props
- Added correct handling of colors
- Updated example with colors and size interpolation
    @chrfalch
    chrfalch committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    d7d3957 View commit details
    Browse the repository at this point in the history

  3. [android] Added support for animating all props with useNativeDriver 

    - Added support for configuration of allowed properties from js
- Fixed color interpolation in interpolation node
- Added support for differentiating props in style and prop nodes
- Made member getUIViewOperationQueue public in UIManager to be able to test if we are currently updating our view so we don't call dispatchViewUpdates to often.
    @chrfalch
    chrfalch committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    cc6911a View commit details
    Browse the repository at this point in the history

  4. Removed podfile changes from branch

    @chrfalch
    chrfalch committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    7ce4990 View commit details
    Browse the repository at this point in the history

  5. [android] Trying to fix failing android test.

    @chrfalch
    chrfalch committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    1dcc656 View commit details
    Browse the repository at this point in the history

  6. [ios] Fixed missing call to configure props in test setup.

    @chrfalch
    chrfalch committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    d2303d4 View commit details
    Browse the repository at this point in the history

  7. [android] added calls to configureProps to get tests to work

    @chrfalch
    chrfalch committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    9f6bd56 View commit details
    Browse the repository at this point in the history

  8. [android] fixed issue where property bags where swapped.

    @chrfalch
    chrfalch committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    c183ceb View commit details
    Browse the repository at this point in the history

  9. [android] Fixed issue with prop bags again..

    @chrfalch
    chrfalch committed Dec 21, 2019
    Configuration menu
    Copy the full SHA
    c5597b5 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2019

  1. Removed property configuration from Javascript side 

    - Removed validateStyles and the Styles whitelist.
- Added static ui thread styles
- Renamed methods after code review
    @chrfalch
    chrfalch committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    5bcec89 View commit details
    Browse the repository at this point in the history

  2. Removed configure props and renamed members 

    - Removed configureProps from iOS
- Renamed members from code review
- Removed styles properties white list
    @chrfalch
    chrfalch committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    7ea0191 View commit details
    Browse the repository at this point in the history

  3. Removed configure props

    @chrfalch
    chrfalch committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    550ecf6 View commit details
    Browse the repository at this point in the history

  4. Added affirmative test for all properties

    @chrfalch
    chrfalch committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    ce3c4ec View commit details
    Browse the repository at this point in the history

  5. Added transform props to whitelist

    @chrfalch
    chrfalch committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    5972744 View commit details
    Browse the repository at this point in the history

  6. Changed parameter for operation to be ReadableMap from WriteableMap

    @chrfalch
    chrfalch committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    f08526e View commit details
    Browse the repository at this point in the history

  7. Added test to verify that the left property is not updated on the ui … 

    …thread.
    @chrfalch
    chrfalch committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    ffebced View commit details
    Browse the repository at this point in the history

  8. Updated member names

    @chrfalch
    chrfalch committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    345f716 View commit details
    Browse the repository at this point in the history

  9. Updated names

    @chrfalch
    chrfalch committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    8f37658 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2019

  1. Moved processing of native props queue to updateProps() function

    @chrfalch
    chrfalch committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    6ac3631 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2020

  1. Inverted list of props to include only layoutProps

    @chrfalch
    chrfalch committed Jan 5, 2020
    Configuration menu
    Copy the full SHA
    fa28aae View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2020

  1. Removed onLayout from layout props

    @chrfalch
    chrfalch committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    5a459b8 View commit details
    Browse the repository at this point in the history

  2. Added addEnqueuedUpdateProp method to be able to configure properties… 

    … that needs to be called through enqueueUpdateViewOnUIManager
    @chrfalch
    chrfalch committed Jan 6, 2020
    Configuration menu
    Copy the full SHA
    f4b7662 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2020

  1. Removed validateStyles

    @chrfalch
    chrfalch committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    f4395cf View commit details
    Browse the repository at this point in the history

  2. Changed layoutProps to an NSSet

    @chrfalch
    chrfalch committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    064b763 View commit details
    Browse the repository at this point in the history